Skip to content

Commit 8472d97

Browse files
tikig21tikig21
committed
Warning fixes
1 parent d0265af commit 8472d97

28 files changed

Lines changed: 909 additions & 909 deletions

‎Test_Numerics/Distributions/Univariate/Test_ChiSquared.cs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -275,15 +275,15 @@ public void Test_CDF()
275275
public void Test_InverseCDF()
276276
{
277277
var x = new ChiSquared(1);
278-
Assert.AreEqual(x.InverseCDF(0.24817036595415071751), 0.09999,1e-04);
279-
Assert.AreEqual(x.InverseCDF(0.68268949213708589717), 1, 1e-04);
280-
Assert.AreEqual(x.InverseCDF(0.9809835), 5.5, 1e-04);
278+
Assert.AreEqual(0.09999, x.InverseCDF(0.24817036595415071751), 1e-04);
279+
Assert.AreEqual(1, x.InverseCDF(0.68268949213708589717), 1e-04);
280+
Assert.AreEqual(5.5, x.InverseCDF(0.9809835), 1e-04);
281281

282282
var x2 = new ChiSquared(2);
283-
Assert.AreEqual(x2.InverseCDF(0), 0);
284-
Assert.AreEqual(x2.InverseCDF(0.04877057), 0.1,1e-04);
285-
Assert.AreEqual(x2.InverseCDF(0.3934693), 1,1e-04);
286-
Assert.AreEqual(x2.InverseCDF(0.9360721), 5.5, 1e-04);
283+
Assert.AreEqual(0, x2.InverseCDF(0));
284+
Assert.AreEqual(0.1, x2.InverseCDF(0.04877057), 1e-04);
285+
Assert.AreEqual(1, x2.InverseCDF(0.3934693),1e-04);
286+
Assert.AreEqual(5.5, x2.InverseCDF(0.9360721), 1e-04);
287287
}
288288
}
289289
}

‎Test_Numerics/Distributions/Univariate/Test_EmpiricalDistribution.cs‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public void Test_ConvolveTwoUniformDistributions()
145145
var convolved = EmpiricalDistribution.Convolve(dist1, dist2, 1000);
146146

147147
// Assert number of points
148-
Assert.AreEqual(1000, convolved.XValues.Count, "Should have exactly 1000 points");
148+
Assert.HasCount(1000, convolved.XValues, "Should have exactly 1000 points");
149149

150150
// Expected: Min ≈ 0, Max ≈ 2, Mean ≈ 1
151151
Assert.AreEqual(0.0, convolved.Minimum, 0.05, "Minimum should be approximately 0");
@@ -191,7 +191,7 @@ public void Test_ConvolveTwoNormalDistributions()
191191
var convolved = EmpiricalDistribution.Convolve(dist1, dist2, 2048);
192192

193193
// Assert number of points
194-
Assert.AreEqual(2048, convolved.XValues.Count, "Should have exactly 2048 points");
194+
Assert.HasCount(2048, convolved.XValues, "Should have exactly 2048 points");
195195

196196
// Expected: For N(0,1) + N(0,1) = N(0, sqrt(2))
197197
// Mean ≈ 0, StdDev ≈ 1.414
@@ -227,7 +227,7 @@ public void Test_ConvolveDifferentRanges()
227227
var convolved = EmpiricalDistribution.Convolve(dist1, dist2, 500);
228228

229229
// Assert number of points
230-
Assert.AreEqual(500, convolved.XValues.Count, "Should have exactly 500 points");
230+
Assert.HasCount(500, convolved.XValues, "Should have exactly 500 points");
231231

232232
// Expected: Range ≈ [5, 25], Mean ≈ 15
233233
Assert.AreEqual(5.0, convolved.Minimum, 0.5, "Minimum should be approximately 5");
@@ -270,8 +270,8 @@ public void Test_ConvolveFiveDistributions()
270270
Assert.AreEqual(convolved.Mean, convolved.Median, 0.5, "Median should be close to mean for symmetric distribution");
271271

272272
// Verify CDF properties
273-
Assert.IsTrue(convolved.CDF(convolved.Minimum) <= 0.01, "CDF at minimum should be close to 0");
274-
Assert.IsTrue(convolved.CDF(convolved.Maximum) >= 0.99, "CDF at maximum should be close to 1");
273+
Assert.IsLessThanOrEqualTo( 0.01, convolved.CDF(convolved.Minimum) );
274+
Assert.IsGreaterThanOrEqualTo(0.99, convolved.CDF(convolved.Maximum));
275275
}
276276

277277
/// <summary>
@@ -311,14 +311,14 @@ public void Test_ConvolveFiveDifferentDistributions()
311311
var convolved = EmpiricalDistribution.Convolve(distributions, 1000);
312312

313313
// Assert number of points
314-
Assert.AreEqual(1000, convolved.XValues.Count, "Should have exactly 1000 points");
314+
Assert.HasCount(1000, convolved.XValues, "Should have exactly 1000 points");
315315

316316
// Compare with expected (allow for numerical error)
317317
double meanError = Math.Abs(convolved.Mean - expectedMean) / expectedMean;
318318
double stdDevError = Math.Abs(convolved.StandardDeviation - expectedStdDev) / expectedStdDev;
319319

320-
Assert.IsTrue(meanError < 0.05, $"Mean error {meanError:P2} should be less than 5%");
321-
Assert.IsTrue(stdDevError < 0.15, $"StdDev error {stdDevError:P2} should be less than 15%");
320+
Assert.IsLessThan(0.05, meanError);
321+
Assert.IsLessThan(0.15, stdDevError);
322322

323323
// Verify range is reasonable
324324
double expectedMin = distributions.Sum(d => d.Minimum);
@@ -347,7 +347,7 @@ public void Test_NonPowerOfTwoPoints()
347347
var convolved = EmpiricalDistribution.Convolve(dist1, dist2, size);
348348

349349
// Assert correct number of points
350-
Assert.AreEqual(size, convolved.XValues.Count, $"Should have exactly {size} points");
350+
Assert.HasCount(size, convolved.XValues, $"Should have exactly {size} points");
351351

352352
// Assert reasonable properties
353353
Assert.AreEqual(1.0, convolved.Mean, 0.1, $"Mean should be approximately 1 for size {size}");

‎Test_Numerics/Distributions/Univariate/Test_Exponential.cs‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@ public void Test_EXP_Quantile()
147147
var EXP = new Exponential(27421d, 25200d);
148148
double q100 = EXP.InverseCDF(0.99d);
149149
double true_100 = 143471d;
150-
Assert.AreEqual((q100 - true_100) / true_100 < 0.01d, true);
150+
Assert.IsLessThan(0.01d, (q100 - true_100) / true_100 );
151151
double p = EXP.CDF(q100);
152152
double true_p = 0.99d;
153-
Assert.AreEqual(p == true_p, true);
153+
Assert.AreEqual(p, true_p);
154154
}
155155

156156
/// <summary>
@@ -172,13 +172,13 @@ public void Test_EXP_StandardError()
172172
var EXP = new Exponential(27421d, 25200d);
173173
double se100 = Math.Sqrt(EXP.QuantileVariance(0.99d, 85, ParameterEstimationMethod.MethodOfMoments));
174174
double true_se100 = 15986d;
175-
Assert.AreEqual((se100 - true_se100) / true_se100 < 0.01d, true);
175+
Assert.IsLessThan(0.01d, (se100 - true_se100) / true_se100);
176176

177177
// Maximum Likelihood
178178
EXP = new Exponential(12629d, 39991d);
179179
se100 = Math.Sqrt(EXP.QuantileVariance(0.99d, 85, ParameterEstimationMethod.MaximumLikelihood));
180180
true_se100 = 20048d;
181-
Assert.AreEqual((se100 - true_se100) / true_se100 < 0.01d, true);
181+
Assert.IsLessThan(0.01d, (se100 - true_se100) / true_se100);
182182
}
183183

184184
/// <summary>
@@ -192,8 +192,8 @@ public void Test_EXP_Partials()
192192
double dQdScale = EXP.QuantileGradient(0.99d)[1];
193193
double true_dLocation = 1.0d;
194194
double true_dScale = 4.60517d;
195-
Assert.AreEqual((dQdLocation - true_dLocation) / true_dLocation < 0.01d, true);
196-
Assert.AreEqual((dQdScale - true_dScale) / true_dScale < 0.01d, true);
195+
Assert.IsLessThan(0.01d, (dQdLocation - true_dLocation) / true_dLocation);
196+
Assert.IsLessThan(0.01d, (dQdScale - true_dScale) / true_dScale);
197197
}
198198

199199
/// <summary>
@@ -203,12 +203,12 @@ public void Test_EXP_Partials()
203203
public void Test_Construction()
204204
{
205205
var EXP = new Exponential(-5, 100);
206-
Assert.AreEqual(EXP.Xi, -5);
207-
Assert.AreEqual(EXP.Alpha, 100);
206+
Assert.AreEqual(-5, EXP.Xi);
207+
Assert.AreEqual(100,EXP.Alpha);
208208

209209
var EXP2 = new Exponential(0, 1);
210-
Assert.AreEqual(EXP2.Xi, 0);
211-
Assert.AreEqual(EXP2.Alpha, 1);
210+
Assert.AreEqual(0, EXP2.Xi);
211+
Assert.AreEqual(1, EXP2.Alpha);
212212
}
213213

214214
/// <summary>
@@ -237,10 +237,10 @@ public void Test_InvalidParameters()
237237
public void Test_ParametersToString()
238238
{
239239
var EXP = new Exponential(1, 1);
240-
Assert.AreEqual(EXP.ParametersToString[0, 0], "Location (ξ)");
241-
Assert.AreEqual(EXP.ParametersToString[1, 0], "Scale (α)");
242-
Assert.AreEqual(EXP.ParametersToString[0, 1], "1");
243-
Assert.AreEqual(EXP.ParametersToString[1, 1], "1");
240+
Assert.AreEqual("Location (ξ)",EXP.ParametersToString[0, 0]);
241+
Assert.AreEqual("Scale (α)", EXP.ParametersToString[1, 0]);
242+
Assert.AreEqual("1", EXP.ParametersToString[0, 1]);
243+
Assert.AreEqual("1", EXP.ParametersToString[1, 1]);
244244
}
245245

246246
/// <summary>
@@ -267,7 +267,7 @@ public void Test_Mean()
267267
Assert.AreEqual(2, EXP.Mean);
268268

269269
var EXP2 = new Exponential(-100, 4);
270-
Assert.AreEqual(EXP2.Mean, -96);
270+
Assert.AreEqual(-96, EXP2.Mean);
271271
}
272272

273273
/// <summary>
@@ -277,10 +277,10 @@ public void Test_Mean()
277277
public void Test_Median()
278278
{
279279
var EXP = new Exponential(0,1);
280-
Assert.AreEqual(EXP.Median, 0.693147, 1e-04);
280+
Assert.AreEqual(0.693147, EXP.Median, 1e-04);
281281

282282
var EXP2 = new Exponential(-100, 1);
283-
Assert.AreEqual(EXP2.Median, -99.306852, 1e-04);
283+
Assert.AreEqual(-99.306852, EXP2.Median, 1e-04);
284284
}
285285

286286
/// <summary>
@@ -290,10 +290,10 @@ public void Test_Median()
290290
public void Test_Mode()
291291
{
292292
var EXP = new Exponential(0,1);
293-
Assert.AreEqual(EXP.Mode, 0);
293+
Assert.AreEqual(0, EXP.Mode);
294294

295295
var EXP2 = new Exponential(-100,1);
296-
Assert.AreEqual(EXP2.Mode, -100);
296+
Assert.AreEqual(-100, EXP2.Mode);
297297
}
298298

299299
/// <summary>
@@ -303,10 +303,10 @@ public void Test_Mode()
303303
public void Test_StandardDeviation()
304304
{
305305
var EXP = new Exponential(0,1);
306-
Assert.AreEqual(EXP.StandardDeviation, 1);
306+
Assert.AreEqual(1, EXP.StandardDeviation);
307307

308308
var EXP2 = new Exponential(-100, 1);
309-
Assert.AreEqual(EXP2.StandardDeviation, 1);
309+
Assert.AreEqual(1, EXP2.StandardDeviation);
310310
}
311311

312312
/// <summary>
@@ -316,7 +316,7 @@ public void Test_StandardDeviation()
316316
public void Test_Skewness()
317317
{
318318
var EXP = new Exponential(0, 1);
319-
Assert.AreEqual(EXP.Skewness, 2);
319+
Assert.AreEqual(2, EXP.Skewness);
320320
}
321321

322322
/// <summary>
@@ -326,7 +326,7 @@ public void Test_Skewness()
326326
public void Test_Kurtosis()
327327
{
328328
var EXP = new Exponential(0, 1);
329-
Assert.AreEqual(EXP.Kurtosis, 9);
329+
Assert.AreEqual(9, EXP.Kurtosis);
330330
}
331331

332332
/// <summary>
@@ -336,10 +336,10 @@ public void Test_Kurtosis()
336336
public void Test_Minimum()
337337
{
338338
var EXP = new Exponential(0, 1);
339-
Assert.AreEqual(EXP.Minimum, 0);
339+
Assert.AreEqual(0, EXP.Minimum);
340340

341341
var EXP2 = new Exponential(-100, 1);
342-
Assert.AreEqual(EXP2.Minimum, -100);
342+
Assert.AreEqual(-100, EXP2.Minimum);
343343
}
344344

345345
/// <summary>
@@ -349,7 +349,7 @@ public void Test_Minimum()
349349
public void Test_Maximum()
350350
{
351351
var EXP = new Exponential(0, 1);
352-
Assert.AreEqual(EXP.Maximum, double.PositiveInfinity);
352+
Assert.AreEqual(double.PositiveInfinity, EXP.Maximum);
353353
}
354354

355355
/// <summary>

0 commit comments

Comments
 (0)