update python libraries

Author: Shannon-ewingsudds-usace

.github/workflows/workflow.yaml

@@ -1,58 +1,58 @@
 name: Update Library
+
 on:
   issues:
-    types: [opened]
+    types: [opened, edited]  # Trigger on new and edited issues
 
 jobs:
   update:
     runs-on: ubuntu-latest
     permissions:
-      contents: write  # Grant write permissions
+      contents: write   # Needed to push changes
+      issues: write     # Needed to comment on issues
+
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Set up Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: '3.x'
 
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-  
-          
       - name: Run Python script
         env:
           ISSUE_BODY: ${{ github.event.issue.body }}
-        run: |
-          python update_library.py
+        run: python update_library.py
 
       - name: Commit changes
+        if: success()
         run: |
           git config --global user.name "github-actions"
           git config --global user.email "actions@github.com"
           git add data/library.json data/library.csv
-          git commit -m "Update library data"
-          git push origin HEAD:${{ github.ref }}
-      - name: Close issue
+          git commit -m "Update library data" || echo "No changes to commit"
+          git push origin main
+
+      - name: Close issue on success
         if: success() && github.event.issue.state == 'open'
-        uses: peter-evans/close-issue@v2  
+        uses: peter-evans/close-issue@v2
         with:
           issue-number: ${{ github.event.issue.number }}
-          comment: "Library updated successfully and issue closed."
-          reason: completed 
-      - name: Handle failure
-        if: failure() 
+          comment: "✅ Library updated successfully and issue closed."
+          reason: completed
+
+      - name: Comment on failure
+        if: failure()
         uses: actions/github-script@v6
         with:
           script: |
             const issue_number = context.payload.issue.number;
-            const comment = "There was an error updating the library. Please check the logs for details.";
+            const body = "⚠️ Validation failed. Please submit valid JSON with `barcode`, `user`, and `action` fields.";
             await github.issues.createComment({
               ...context.repo,
               issue_number,
-              body: comment
+              body
             });
             await github.issues.update({
               ...context.repo,

update_library.py

@@ -1,11 +1,33 @@
 import json
 import csv
 import os
+import sys
 
 # Load issue body from environment variable
-issue_body = os.environ["ISSUE_BODY"]  # GitHub Actions will pass this variable
-data = json.loads(issue_body)
+issue_body = os.environ.get("ISSUE_BODY", "")
 
+try:
+    # Try to parse JSON
+    data = json.loads(issue_body)
+
+    # Validate required keys
+    required_keys = {"barcode", "user", "action"}
+    if not isinstance(data, dict):
+        raise ValueError("Issue body is not a JSON object")
+
+    missing = required_keys - data.keys()
+    if missing:
+        raise ValueError(f"Missing required keys: {missing}")
+
+except json.JSONDecodeError:
+    print("❌ Issue body is not valid JSON.")
+    sys.exit(1)
+
+except ValueError as e:
+    print(f"❌ Validation error: {e}")
+    sys.exit(1)
+
+# If we reach here, JSON is valid and has required fields
 barcode = data["barcode"]
 user = data["user"]
 action = data["action"]
@@ -15,21 +37,24 @@
     books = json.load(f)
 
 # Update book status
+updated = False
 for book in books:
     if book["Barcode"] == barcode:
         if action == "checkout":
             book["Status"] = "Checked Out"
             book["User"] = user
+            updated = True
         elif action == "checkin":
             book["Status"] = "Available"
             book["User"] = ""
+            updated = True
+
+if not updated:
+    print(f"⚠️ No book found with barcode {barcode}.")
+    sys.exit(1)
 
 # Save updated library data
 with open("data/library.json", "w") as f:
     json.dump(books, f, indent=2)
 
-with open("data/library.csv", "w", newline="") as f:
-    writer = csv.DictWriter(f, fieldnames=["Book Title", "Author", "Barcode", "Status", "User"])
-    writer.writeheader()
-    writer.writerows(books)
-    
+with open("data/library