Fix --dump-test-list (#266)

We moved the params parsing partially to the Params which was not use in cli.js
Directly use the cli-only arguments in cli.js instead.

Author: camillobruni

cli.js

@@ -109,12 +109,15 @@ function parseCliFlag(argument) {
         throw Error(message);
     }
     let value = parts.slice(1).join("=");
-    if (flagName === "no-prefetch") value = "false";
+    if (flagName.startsWith("no-")) value = "false";
     else if (value === "") value = "true";
     cliParams.set(CLI_PARAMS[flagName].param, value);
 }
 
 
+const printHelp = cliParams.delete("help");
+const dumpTestList = cliParams.delete("dumpTestList");
+
 if (cliArgs.length) {
     let tests = cliParams.has("test") ? cliParams.get("tests").split(",") : []
     tests = tests.concat(cliArgs);
@@ -126,7 +129,6 @@ if (cliParams.size)
 
 load("./utils/params.js");
 
-
 async function runJetStream() {
     try {
         await JetStream.initialize();
@@ -169,10 +171,11 @@ function help(message=undefined) {
     }
 }
 
-if (cliParams.has("help")) {
+
+if (printHelp) {
     help();
-} else if (cliParams.has("dumpTestList")) {
-  JetStream.dumpTestList();
+} else if (dumpTestList) {
+    JetStream.dumpTestList();
 } else {
-  runJetStream();
+    runJetStream();
 }

tests/run-shell.mjs

@@ -44,6 +44,13 @@ const TESTS = [
             return runTest("UnitTests", () => sh(shell_binary, UNIT_TEST_PATH));
         },
     },
+    {
+        name: "CLI Help",
+        tags: ["all", "main", "help"],
+        run(shell_binary) {
+            return runCLITest("Cli Help", shell_binary, "--help");
+        },
+    },
     {
         name: "Single Suite",
         tags: ["all", "main", "single"],

utils/params.js

@@ -45,7 +45,6 @@ class Params {
     RAMification = false;
     forceGC = false;
     dumpJSONResults = false;
-    dumpTestList = false;
     // Override iteration and worst-case counts per workload.
     // Example:
     //   testIterationCountMap = { "acorn-wtb": 5 };
@@ -70,7 +69,6 @@ class Params {
         this.RAMification = this._parseBooleanParam(sourceParams, "RAMification");
         this.dumpJSONResults = this._parseBooleanParam(sourceParams, "dumpJSONResults");
         this.groupDetails = this._parseBooleanParam(sourceParams, "groupDetails");
-        this.dumpTestList = this._parseBooleanParam(sourceParams, "dumpTestList");
         this.forceGC = this._parseBooleanParam(sourceParams, "forceGC");
 
         this.customPreIterationCode = this._parseStringParam(sourceParams, "customPreIterationCode");