Skip to content

Commit 9ba4acb

Browse files
authored
Merge pull request #189 from WengLab-InformaticsResearch/jaeger
Jaeger
2 parents 77eb199 + 0dc421d commit 9ba4acb

3 files changed

Lines changed: 14 additions & 6 deletions

File tree

cohd/app.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from opentelemetry.sdk.trace.export import BatchSpanProcessor
1212
from opentelemetry.exporter.jaeger.thrift import JaegerExporter
1313
from opentelemetry.instrumentation.requests import RequestsInstrumentor
14+
from opentelemetry.instrumentation.pymysql import PyMySQLInstrumentor
1415

1516
#########
1617
# INITS #
@@ -50,17 +51,17 @@
5051
logging.info('About to instrument app for OTEL')
5152
# set the service name for our trace provider
5253
# this will tag every trace with the service name given
54+
otel_service_name = app.config.get('OTEL_SERVICE_NAME', 'COHD')
5355
tp = TracerProvider(
54-
resource=Resource.create({telemetery_service_name_key: 'COHD'})
56+
resource=Resource.create({telemetery_service_name_key: otel_service_name})
5557
)
5658
# create an exporter to jaeger
57-
jaeger_host = 'jaeger'
59+
jaeger_host = app.config.get('JAEGER_HOST', 'jaeger-otel-agent.sri')
60+
jaeger_port = app.config.get('JAEGER_PORT', 6831)
5861
deployment_env = app.config.get('DEPLOYMENT_ENV', 'dev')
59-
if deployment_env[:4] == 'ITRB':
60-
jaeger_host = 'jaeger-otel-agent.sri'
6162
jaeger_exporter = JaegerExporter(
6263
agent_host_name=jaeger_host,
63-
agent_port=6831,
64+
agent_port=jaeger_port,
6465
)
6566
# here we use the exporter to export each span in a trace
6667
tp.add_span_processor(
@@ -74,4 +75,5 @@
7475
FlaskInstrumentor().instrument_app(app,
7576
excluded_urls=otel_excluded_urls)
7677
RequestsInstrumentor().instrument()
78+
PyMySQLInstrumentor().instrument()
7779
logging.info('Finished instrumenting app for OTEL')

cohd/cohd_flask.conf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,10 @@ CACHE_THRESHOLD = 100000
77
DEV_KEY = 'CHANGE_ME'
88
DATABASES = ['cohd']
99

10+
# OpenTelemetry Settings
11+
OTEL_SERVICE_NAME = 'COHD'
12+
JAEGER_HOST = 'jaeger-otel-agent.sri'
13+
JAEGER_PORT = 6831
14+
1015
# Google Analytics: uncomment and set tracking ID to use Google Analytics
1116
# GA_TID = 'UA-XXXXX-Y'

requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,5 @@ linkml-runtime<1.6.0
1414
opentelemetry-sdk
1515
opentelemetry-instrumentation-flask
1616
opentelemetry-exporter-jaeger
17-
opentelemetry-instrumentation-requests
17+
opentelemetry-instrumentation-requests
18+
opentelemetry-instrumentation-pymysql

0 commit comments

Comments
 (0)