Skip to content

Commit 98d2bdb

Browse files
authored
fix: JsonRPC errors should have a 'data' field not a 'details' field. (#790)
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
1 parent 5ae111f commit 98d2bdb

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

client/transport/jsonrpc/src/test/java/org/a2aproject/sdk/client/transport/jsonrpc/JsonMessages.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ public class JsonMessages {
216216
"error": {
217217
"code": -32702,
218218
"message": "Invalid parameters",
219-
"details": {"info": "Hello world"}
219+
"data": {"info": "Hello world"}
220220
}
221221
}""";
222222

client/transport/jsonrpc/src/test/java/org/a2aproject/sdk/client/transport/jsonrpc/JsonStreamingMessages.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public class JsonStreamingMessages {
9999
"error": {
100100
"code": -32602,
101101
"message": "Invalid parameters",
102-
"details": {"info": "Missing required field"}
102+
"data": {"info": "Missing required field"}
103103
}
104104
}""";
105105

spec-grpc/src/main/java/org/a2aproject/sdk/grpc/utils/JSONRPCUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,8 +392,8 @@ private static A2AError processError(JsonObject error) {
392392
String message = error.has("message") ? error.get("message").getAsString() : null;
393393
Integer code = error.has("code") ? error.get("code").getAsInt() : null;
394394
Map<String, Object> details = null;
395-
if (error.has("details") && error.get("details").isJsonObject()) {
396-
details =GSON.fromJson(error.get("details"), Map.class);
395+
if (error.has("data") && error.get("data").isJsonObject()) {
396+
details =GSON.fromJson(error.get("data"), Map.class);
397397
}
398398
if (code != null) {
399399
A2AErrorCodes errorCode = A2AErrorCodes.fromCode(code);
@@ -606,7 +606,7 @@ public static String toJsonRPCErrorResponse(Object requestId, A2AError error) {
606606
output.name("code").value(error.getCode());
607607
output.name("message").value(error.getMessage());
608608
if (!error.getDetails().isEmpty()) {
609-
output.name("details");
609+
output.name("data");
610610
GSON.toJson(error.getDetails(), Map.class, output);
611611
}
612612
output.endObject();

0 commit comments

Comments
 (0)