Skip to content

Commit 1426720

Browse files
committed
fix: incorporate latest 1.0 proto changes
Mainly a2aproject/A2A#1500 which required many changes. Generated from a2aproject/A2A@aca981c. `buf.gen.yaml` is updated to `main` again.
1 parent 0ebca93 commit 1426720

42 files changed

Lines changed: 394 additions & 536 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

buf.gen.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
version: v2
33
inputs:
44
- git_repo: https://github.com/a2aproject/A2A.git
5-
ref: 1997c9d63058ca0b89361a7d6e508f4641a6f68b
5+
ref: main
66
subdir: specification
77
managed:
88
enabled: true

src/a2a/client/base_client.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from a2a.types.a2a_pb2 import (
1515
AgentCard,
1616
CancelTaskRequest,
17-
CreateTaskPushNotificationConfigRequest,
1817
DeleteTaskPushNotificationConfigRequest,
1918
GetExtendedAgentCardRequest,
2019
GetTaskPushNotificationConfigRequest,
@@ -77,7 +76,7 @@ async def send_message(
7776
config = SendMessageConfiguration(
7877
accepted_output_modes=self._config.accepted_output_modes,
7978
blocking=not self._config.polling,
80-
push_notification_config=(
79+
task_push_notification_config=(
8180
self._config.push_notification_configs[0]
8281
if self._config.push_notification_configs
8382
else None
@@ -195,7 +194,7 @@ async def cancel_task(
195194

196195
async def create_task_push_notification_config(
197196
self,
198-
request: CreateTaskPushNotificationConfigRequest,
197+
request: TaskPushNotificationConfig,
199198
*,
200199
context: ClientCallContext | None = None,
201200
extensions: list[str] | None = None,

src/a2a/client/client.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
from a2a.types.a2a_pb2 import (
1616
AgentCard,
1717
CancelTaskRequest,
18-
CreateTaskPushNotificationConfigRequest,
1918
DeleteTaskPushNotificationConfigRequest,
2019
GetExtendedAgentCardRequest,
2120
GetTaskPushNotificationConfigRequest,
@@ -25,7 +24,6 @@
2524
ListTasksRequest,
2625
ListTasksResponse,
2726
Message,
28-
PushNotificationConfig,
2927
SendMessageConfiguration,
3028
StreamResponse,
3129
SubscribeToTaskRequest,
@@ -72,8 +70,8 @@ class ClientConfig:
7270
accepted_output_modes: list[str] = dataclasses.field(default_factory=list)
7371
"""The set of accepted output modes for the client."""
7472

75-
push_notification_configs: list[PushNotificationConfig] = dataclasses.field(
76-
default_factory=list
73+
push_notification_configs: list[TaskPushNotificationConfig] = (
74+
dataclasses.field(default_factory=list)
7775
)
7876
"""Push notification configurations to use for every request."""
7977

@@ -180,7 +178,7 @@ async def cancel_task(
180178
@abstractmethod
181179
async def create_task_push_notification_config(
182180
self,
183-
request: CreateTaskPushNotificationConfigRequest,
181+
request: TaskPushNotificationConfig,
184182
*,
185183
context: ClientCallContext | None = None,
186184
extensions: list[str] | None = None,

src/a2a/client/transports/base.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from a2a.types.a2a_pb2 import (
99
AgentCard,
1010
CancelTaskRequest,
11-
CreateTaskPushNotificationConfigRequest,
1211
DeleteTaskPushNotificationConfigRequest,
1312
GetExtendedAgentCardRequest,
1413
GetTaskPushNotificationConfigRequest,
@@ -97,7 +96,7 @@ async def cancel_task(
9796
@abstractmethod
9897
async def create_task_push_notification_config(
9998
self,
100-
request: CreateTaskPushNotificationConfigRequest,
99+
request: TaskPushNotificationConfig,
101100
*,
102101
context: ClientCallContext | None = None,
103102
extensions: list[str] | None = None,

src/a2a/client/transports/grpc.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
from a2a.types.a2a_pb2 import (
2828
AgentCard,
2929
CancelTaskRequest,
30-
CreateTaskPushNotificationConfigRequest,
3130
DeleteTaskPushNotificationConfigRequest,
3231
GetExtendedAgentCardRequest,
3332
GetTaskPushNotificationConfigRequest,
@@ -208,7 +207,7 @@ async def cancel_task(
208207
@_handle_grpc_exception
209208
async def create_task_push_notification_config(
210209
self,
211-
request: CreateTaskPushNotificationConfigRequest,
210+
request: TaskPushNotificationConfig,
212211
*,
213212
context: ClientCallContext | None = None,
214213
extensions: list[str] | None = None,

src/a2a/client/transports/jsonrpc.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
from a2a.types.a2a_pb2 import (
2222
AgentCard,
2323
CancelTaskRequest,
24-
CreateTaskPushNotificationConfigRequest,
2524
DeleteTaskPushNotificationConfigRequest,
2625
GetExtendedAgentCardRequest,
2726
GetTaskPushNotificationConfigRequest,
@@ -223,7 +222,7 @@ async def cancel_task(
223222

224223
async def create_task_push_notification_config(
225224
self,
226-
request: CreateTaskPushNotificationConfigRequest,
225+
request: TaskPushNotificationConfig,
227226
*,
228227
context: ClientCallContext | None = None,
229228
extensions: list[str] | None = None,

src/a2a/client/transports/rest.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
from a2a.types.a2a_pb2 import (
2121
AgentCard,
2222
CancelTaskRequest,
23-
CreateTaskPushNotificationConfigRequest,
2423
DeleteTaskPushNotificationConfigRequest,
2524
GetExtendedAgentCardRequest,
2625
GetTaskPushNotificationConfigRequest,
@@ -196,7 +195,7 @@ async def cancel_task(
196195

197196
async def create_task_push_notification_config(
198197
self,
199-
request: CreateTaskPushNotificationConfigRequest,
198+
request: TaskPushNotificationConfig,
200199
*,
201200
context: ClientCallContext | None = None,
202201
extensions: list[str] | None = None,

src/a2a/client/transports/tenant_decorator.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from a2a.types.a2a_pb2 import (
66
AgentCard,
77
CancelTaskRequest,
8-
CreateTaskPushNotificationConfigRequest,
98
DeleteTaskPushNotificationConfigRequest,
109
GetExtendedAgentCardRequest,
1110
GetTaskPushNotificationConfigRequest,
@@ -106,7 +105,7 @@ async def cancel_task(
106105

107106
async def create_task_push_notification_config(
108107
self,
109-
request: CreateTaskPushNotificationConfigRequest,
108+
request: TaskPushNotificationConfig,
110109
*,
111110
context: ClientCallContext | None = None,
112111
extensions: list[str] | None = None,

src/a2a/compat/v0_3/conversions.py

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -271,9 +271,9 @@ def to_compat_authentication_info(
271271

272272
def to_core_push_notification_config(
273273
compat_config: types_v03.PushNotificationConfig,
274-
) -> pb2_v10.PushNotificationConfig:
274+
) -> pb2_v10.TaskPushNotificationConfig:
275275
"""Convert push notification config to v1.0 core type."""
276-
core_config = pb2_v10.PushNotificationConfig(url=compat_config.url)
276+
core_config = pb2_v10.TaskPushNotificationConfig(url=compat_config.url)
277277
if compat_config.id:
278278
core_config.id = compat_config.id
279279
if compat_config.token:
@@ -286,11 +286,11 @@ def to_core_push_notification_config(
286286

287287

288288
def to_compat_push_notification_config(
289-
core_config: pb2_v10.PushNotificationConfig,
289+
core_config: pb2_v10.TaskPushNotificationConfig,
290290
) -> types_v03.PushNotificationConfig:
291291
"""Convert push notification config to v0.3 compat type."""
292292
return types_v03.PushNotificationConfig(
293-
url=core_config.url,
293+
url=core_config.url if core_config.url else '',
294294
id=core_config.id if core_config.id else None,
295295
token=core_config.token if core_config.token else None,
296296
authentication=to_compat_authentication_info(core_config.authentication)
@@ -312,7 +312,7 @@ def to_core_send_message_configuration(
312312
compat_config.accepted_output_modes
313313
)
314314
if compat_config.push_notification_config:
315-
core_config.push_notification_config.CopyFrom(
315+
core_config.task_push_notification_config.CopyFrom(
316316
to_core_push_notification_config(
317317
compat_config.push_notification_config
318318
)
@@ -333,9 +333,9 @@ def to_compat_send_message_configuration(
333333
if core_config.accepted_output_modes
334334
else None,
335335
push_notification_config=to_compat_push_notification_config(
336-
core_config.push_notification_config
336+
core_config.task_push_notification_config
337337
)
338-
if core_config.HasField('push_notification_config')
338+
if core_config.HasField('task_push_notification_config')
339339
else None,
340340
history_length=core_config.history_length
341341
if core_config.HasField('history_length')
@@ -1008,7 +1008,7 @@ def to_core_task_push_notification_config(
10081008
task_id=compat_config.task_id
10091009
)
10101010
if compat_config.push_notification_config:
1011-
core_config.push_notification_config.CopyFrom(
1011+
core_config.MergeFrom(
10121012
to_core_push_notification_config(
10131013
compat_config.push_notification_config
10141014
)
@@ -1022,10 +1022,8 @@ def to_compat_task_push_notification_config(
10221022
"""Convert task push notification config to v0.3 compat type."""
10231023
return types_v03.TaskPushNotificationConfig(
10241024
task_id=core_config.task_id,
1025-
push_notification_config=to_compat_push_notification_config(
1026-
core_config.push_notification_config
1027-
)
1028-
if core_config.HasField('push_notification_config')
1025+
push_notification_config=to_compat_push_notification_config(core_config)
1026+
if core_config.url
10291027
else types_v03.PushNotificationConfig(url=''),
10301028
)
10311029

@@ -1179,13 +1177,13 @@ def to_compat_delete_task_push_notification_config_request(
11791177

11801178
def to_core_create_task_push_notification_config_request(
11811179
compat_req: types_v03.SetTaskPushNotificationConfigRequest,
1182-
) -> pb2_v10.CreateTaskPushNotificationConfigRequest:
1180+
) -> pb2_v10.TaskPushNotificationConfig:
11831181
"""Convert create task push notification config request to v1.0 core type."""
1184-
core_req = pb2_v10.CreateTaskPushNotificationConfigRequest(
1182+
core_req = pb2_v10.TaskPushNotificationConfig(
11851183
task_id=compat_req.params.task_id
11861184
)
11871185
if compat_req.params.push_notification_config:
1188-
core_req.config.CopyFrom(
1186+
core_req.MergeFrom(
11891187
to_core_push_notification_config(
11901188
compat_req.params.push_notification_config
11911189
)
@@ -1194,7 +1192,7 @@ def to_core_create_task_push_notification_config_request(
11941192

11951193

11961194
def to_compat_create_task_push_notification_config_request(
1197-
core_req: pb2_v10.CreateTaskPushNotificationConfigRequest,
1195+
core_req: pb2_v10.TaskPushNotificationConfig,
11981196
request_id: str | int,
11991197
) -> types_v03.SetTaskPushNotificationConfigRequest:
12001198
"""Convert create task push notification config request to v0.3 compat type."""
@@ -1203,9 +1201,9 @@ def to_compat_create_task_push_notification_config_request(
12031201
params=types_v03.TaskPushNotificationConfig(
12041202
task_id=core_req.task_id,
12051203
push_notification_config=to_compat_push_notification_config(
1206-
core_req.config
1204+
core_req
12071205
)
1208-
if core_req.HasField('config')
1206+
if core_req.url
12091207
else types_v03.PushNotificationConfig(url=''),
12101208
),
12111209
)

src/a2a/compat/v0_3/grpc_transport.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ async def cancel_task(
264264
@_handle_grpc_exception
265265
async def create_task_push_notification_config(
266266
self,
267-
request: a2a_pb2.CreateTaskPushNotificationConfigRequest,
267+
request: a2a_pb2.TaskPushNotificationConfig,
268268
*,
269269
context: ClientCallContext | None = None,
270270
extensions: list[str] | None = None,

0 commit comments

Comments
 (0)