Skip to content

Commit 15fb9b7

Browse files
kdziedzic70Krzysztof Dziedzicishymko
authored
ci: bump itk version and fix json rpc agent interface specification (#938)
# Description There was a bug that did not specify separate agent interfaces in SUT for jsonrpc transport - which resulted with go-v10 interface - communicating with python-v10 through v03 compat for jsonrpc - [ ] Follow the [`CONTRIBUTING` Guide](https://github.com/a2aproject/a2a-python/blob/main/CONTRIBUTING.md). - [ ] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [ ] Ensure the tests and linter pass (Run `bash scripts/format.sh` from the repository root to format) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕 Co-authored-by: Krzysztof Dziedzic <dziedzick@google.com> Co-authored-by: Ivan Shymko <ishymko@google.com>
1 parent fe5de77 commit 15fb9b7

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/itk.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ jobs:
2828
run: bash run_itk.sh
2929
working-directory: itk
3030
env:
31-
A2A_SAMPLES_REVISION: itk-v0.1-alpha
31+
A2A_SAMPLES_REVISION: itk-v.0.11-alpha

itk/main.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,14 @@ async def main_async(http_port: int, grpc_port: int) -> None:
263263
AgentInterface(
264264
protocol_binding=TransportProtocol.JSONRPC,
265265
url=f'http://127.0.0.1:{http_port}/jsonrpc/',
266+
protocol_version='1.0',
267+
)
268+
)
269+
interfaces.append(
270+
AgentInterface(
271+
protocol_binding=TransportProtocol.JSONRPC,
272+
url=f'http://127.0.0.1:{http_port}/jsonrpc/',
273+
protocol_version='0.3',
266274
)
267275
)
268276
interfaces.append(

0 commit comments

Comments
 (0)