Remove unncessary function calls from API

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

vulnerabilities/api.py

@@ -88,10 +88,8 @@ class MinimalPackageSerializer(BaseResourceSerializer):
     """
 
     def get_affected_vulnerabilities(self, package):
-        parent_affected_vulnerabilities = package.fixed_package_details.get("vulnerabilities") or []
-
         affected_vulnerabilities = [
-            self.get_vulnerability(vuln) for vuln in parent_affected_vulnerabilities
+            self.get_vulnerability(vuln) for vuln in package.get_affecting_vulnerabilities()
         ]
 
         return affected_vulnerabilities

vulnerabilities/tests/test_api.py

@@ -455,59 +455,48 @@ def test_api_packages_all_num_queries(self):
 
     def test_api_packages_single_num_queries(self):
         with self.assertNumQueries(10):
-            self.csrf_client.get(
-                f"/api/packages/{self.pkg_2_14_0_rc1.id}", format="json"
-            )
-    
+            self.csrf_client.get(f"/api/packages/{self.pkg_2_14_0_rc1.id}", format="json")
+
     def test_api_packages_single_with_purl_in_query_num_queries(self):
         with self.assertNumQueries(11):
-            self.csrf_client.get(
-                f"/api/packages/?purl={self.pkg_2_14_0_rc1.purl}", format="json"
-            )
-    
+            self.csrf_client.get(f"/api/packages/?purl={self.pkg_2_14_0_rc1.purl}", format="json")
+
     def test_api_packages_single_with_purl_no_version_in_query_num_queries(self):
-        with self.assertNumQueries(98):
+        with self.assertNumQueries(88):
             self.csrf_client.get(
-                f"/api/packages/?purl=pkg:maven/com.fasterxml.jackson.core/jackson-databind", format="json"
+                f"/api/packages/?purl=pkg:maven/com.fasterxml.jackson.core/jackson-databind",
+                format="json",
             )
-    
+
     def test_api_packages_bulk_search(self):
-        with self.assertNumQueries(71):
-            packages = [
-                self.pkg_2_12_6,
-                self.pkg_2_12_6_1,
-                self.pkg_2_13_1
-            ]
+        with self.assertNumQueries(63):
+            packages = [self.pkg_2_12_6, self.pkg_2_12_6_1, self.pkg_2_13_1]
             purls = [p.purl for p in packages]
 
-            data = {'purls': purls, 'purl_only': False, 'plain_purl': True}
+            data = {"purls": purls, "purl_only": False, "plain_purl": True}
 
             resp = self.csrf_client.post(
                 f"/api/packages/bulk_search",
                 data=json.dumps(data),
                 content_type="application/json",
             ).json()
-    
+
     def test_api_packages_with_lookup(self):
-        with self.assertNumQueries(20):
-            data = {'purl': self.pkg_2_12_6.purl}
+        with self.assertNumQueries(18):
+            data = {"purl": self.pkg_2_12_6.purl}
 
             resp = self.csrf_client.post(
                 f"/api/packages/lookup",
                 data=json.dumps(data),
                 content_type="application/json",
             ).json()
-    
+
     def test_api_packages_bulk_lookup(self):
-        with self.assertNumQueries(71):
-            packages = [
-                self.pkg_2_12_6,
-                self.pkg_2_12_6_1,
-                self.pkg_2_13_1
-            ]
+        with self.assertNumQueries(63):
+            packages = [self.pkg_2_12_6, self.pkg_2_12_6_1, self.pkg_2_13_1]
             purls = [p.purl for p in packages]
 
-            data = {'purls': purls}
+            data = {"purls": purls}
 
             resp = self.csrf_client.post(
                 f"/api/packages/bulk_lookup",

vulnerablecode/settings.py

@@ -287,6 +287,9 @@
 
 
 if DEBUG_TOOLBAR:
+    # Uncomment this to get pyinstrument profiles
+    # PYINSTRUMENT_PROFILE_DIR = "profiles"
+
     INSTALLED_APPS += ("debug_toolbar",)
 
     MIDDLEWARE += (