Skip to content

Commit b343278

Browse files
committed
feat: extract the Angular major version in the project as the requiredVersion
1 parent fbfdc5c commit b343278

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

src/webpack.config.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import { env } from 'process';
44
import webpack from 'webpack';
55
import { readJsonFromVisual } from './utils.js';
66

7+
const ModuleFederationPlugin = webpack.container.ModuleFederationPlugin;
8+
79
const ngJson = readJsonFromVisual('angular.json');
810
const projectName = env.VISUAL_NAME!;
911
const visualRoot = ngJson.projects[projectName].root;
@@ -25,7 +27,9 @@ getDirectories(sourceRoot).forEach(dir => {
2527
}
2628
});
2729

28-
const ModuleFederationPlugin = webpack.container.ModuleFederationPlugin;
30+
const ngCorePkgJson = readJsonFromVisual('node_modules/@angular/core/package.json');
31+
const ngVersion = ngCorePkgJson.version;
32+
const ngMajorVersion = ngVersion.split('.')[0];
2933

3034
export default {
3135
devServer: {
@@ -52,17 +56,17 @@ export default {
5256
'@angular/core': {
5357
singleton: true,
5458
eager: true,
55-
requiredVersion: '^18.0.0',
59+
requiredVersion: `^${ngMajorVersion}.0.0`,
5660
},
5761
'@angular/common': {
5862
singleton: true,
5963
eager: true,
60-
requiredVersion: '^18.0.0',
64+
requiredVersion: `^${ngMajorVersion}.0.0`,
6165
},
6266
'@angular/forms': {
6367
singleton: true,
6468
eager: true,
65-
requiredVersion: '^18.0.0',
69+
requiredVersion: `^${ngMajorVersion}.0.0`,
6670
},
6771
'rxjs': {
6872
singleton: true,

0 commit comments

Comments
 (0)