Fix bulk commands only operating on first page of alerts (#401)

All bulk commands (delete, ack, close, tag, untag, shelve, unshelve,
unack, update, action, note) called get_alerts() without pagination,
which defaults to page 1 with 50 results. If more than 50 alerts
matched, the remaining alerts were silently skipped.

Add get_all_alerts() method that paginates through all results and
use it in all 11 bulk commands.

Fixes #227

Co-authored-by: Nick Satterly <nsa@softpay.io>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: 3 people

alertaclient/api.py

@@ -110,6 +110,17 @@ def get_alerts(self, query=None, page=1, page_size=None):
         r = self.http.get('/alerts', query, page=page, page_size=page_size)
         return [Alert.parse(a) for a in r['alerts']]
 
+    def get_all_alerts(self, query=None, page_size=1000):
+        alerts = []
+        page = 1
+        while True:
+            r = self.http.get('/alerts', query, page=page, page_size=page_size)
+            alerts.extend([Alert.parse(a) for a in r['alerts']])
+            if len(r['alerts']) < page_size:
+                break
+            page += 1
+        return alerts
+
     def get_history(self, query=None, page=1, page_size=None):
         r = self.http.get('/alerts/history', query, page=page, page_size=page_size)
         return [RichHistory.parse(a) for a in r['history']]

alertaclient/commands/cmd_ack.py

@@ -20,6 +20,6 @@ def cli(obj, ids, query, filters, text):
         else:
             query = build_query(filters)
         total, _, _ = client.get_count(query)
-        ids = [a.id for a in client.get_alerts(query)]
+        ids = [a.id for a in client.get_all_alerts(query)]
 
     action_progressbar(client, action='ack', ids=ids, label=f'Acking {total} alerts', text=text)

alertaclient/commands/cmd_action.py

@@ -21,7 +21,7 @@ def cli(obj, action, ids, query, filters, text):
         else:
             query = build_query(filters)
         total, _, _ = client.get_count(query)
-        ids = [a.id for a in client.get_alerts(query)]
+        ids = [a.id for a in client.get_all_alerts(query)]
 
     label = f'Action ({action}) {total} alerts'
     action_progressbar(client, action=action, ids=ids, label=label, text=text)

alertaclient/commands/cmd_close.py

@@ -20,6 +20,6 @@ def cli(obj, ids, query, filters, text):
         else:
             query = build_query(filters)
         total, _, _ = client.get_count(query)
-        ids = [a.id for a in client.get_alerts(query)]
+        ids = [a.id for a in client.get_all_alerts(query)]
 
     action_progressbar(client, action='close', ids=ids, label=f'Closing {total} alerts', text=text)

alertaclient/commands/cmd_delete.py

@@ -21,7 +21,7 @@ def cli(obj, ids, query, filters):
         else:
             query = build_query(filters)
         total, _, _ = client.get_count(query)
-        ids = [a.id for a in client.get_alerts(query)]
+        ids = [a.id for a in client.get_all_alerts(query)]
 
     with click.progressbar(ids, label=f'Deleting {total} alerts') as bar:
         for id in bar:

alertaclient/commands/cmd_note.py

@@ -40,7 +40,7 @@ def cli(obj, alert_ids, query, filters, text, delete):
             else:
                 query = build_query(filters)
             total, _, _ = client.get_count(query)
-            alert_ids = [a.id for a in client.get_alerts(query)]
+            alert_ids = [a.id for a in client.get_all_alerts(query)]
 
         with click.progressbar(alert_ids, label=f'Add note to {total} alerts') as bar:
             for id in bar:

alertaclient/commands/cmd_shelve.py

@@ -21,7 +21,7 @@ def cli(obj, ids, query, filters, timeout, text):
         else:
             query = build_query(filters)
         total, _, _ = client.get_count(query)
-        ids = [a.id for a in client.get_alerts(query)]
+        ids = [a.id for a in client.get_all_alerts(query)]
 
     action_progressbar(client, action='shelve', ids=ids,
                        label=f'Shelving {total} alerts', text=text, timeout=timeout)

alertaclient/commands/cmd_tag.py

@@ -20,7 +20,7 @@ def cli(obj, ids, query, filters, tags):
         else:
             query = build_query(filters)
         total, _, _ = client.get_count(query)
-        ids = [a.id for a in client.get_alerts(query)]
+        ids = [a.id for a in client.get_all_alerts(query)]
 
     with click.progressbar(ids, label=f'Tagging {total} alerts') as bar:
         for id in bar:

alertaclient/commands/cmd_unack.py

@@ -20,6 +20,6 @@ def cli(obj, ids, query, filters, text):
         else:
             query = build_query(filters)
         total, _, _ = client.get_count(query)
-        ids = [a.id for a in client.get_alerts(query)]
+        ids = [a.id for a in client.get_all_alerts(query)]
 
     action_progressbar(client, action='unack', ids=ids, label=f'Un-acking {total} alerts', text=text)

alertaclient/commands/cmd_unshelve.py

@@ -20,6 +20,6 @@ def cli(obj, ids, query, filters, text):
         else:
             query = build_query(filters)
         total, _, _ = client.get_count(query)
-        ids = [a.id for a in client.get_alerts(query)]
+        ids = [a.id for a in client.get_all_alerts(query)]
 
     action_progressbar(client, 'unshelve', ids, label=f'Un-shelving {total} alerts', text=text)