AMBARI-26563: Replace deprecated logger.warn() with logger.warning() (#4095)

Author: guluo2016

ambari-agent/src/main/python/ambari_agent/AlertStatusReporter.py

@@ -53,7 +53,7 @@ def run(self):
     Run an endless loop which reports all the alert statuses got from collector
     """
     if self.alert_reports_interval == 0:
-      logger.warn(
+      logger.warning(
         "AlertStatusReporter is turned off. Some functionality might not work correctly."
       )
       return
@@ -142,7 +142,7 @@ def get_changed_alerts(self, alerts):
         ):
           changed_alerts.append(alert)
       else:
-        logger.warn(
+        logger.warning(
           "Cannot find alert definition for alert='{0}', alert_state='{1}'.".format(
             alert_name, alert_state
           )

ambari-agent/src/main/python/ambari_agent/AmbariConfig.py

@@ -162,7 +162,7 @@ def get_resolved_config(cls, home_dir=""):
         raise Exception(f"No config found at {configPath}, use default")
 
     except Exception as err:
-      logger.warn(err)
+      logger.warning(err)
     setattr(cls, "_conf_cache", config)
     return config
 

ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py

@@ -37,7 +37,7 @@ def run(self):
     Run an endless loop which reports all the commands results (IN_PROGRESS, FAILED, COMPLETE) every self.command_reports_interval seconds.
     """
     if self.command_reports_interval == 0:
-      logger.warn(
+      logger.warning(
         "CommandStatusReporter is turned off. Some functionality might not work correctly."
       )
       return

ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py

@@ -56,7 +56,7 @@ def run(self):
     Run an endless loop which executes all status commands every 'status_commands_run_interval' seconds.
     """
     if self.status_commands_run_interval == 0:
-      self.logger.warn(
+      self.logger.warning(
         "ComponentStatusExecutor is turned off. Some functionality might not work correctly."
       )
       return

ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py

@@ -147,7 +147,7 @@ def cancel_command(self, task_id, reason):
         log_process_information(logger)
         shell.kill_process_with_children(pid)
       else:
-        logger.warn(f"Unable to find process associated with taskId = {task_id}")
+        logger.warning(f"Unable to find process associated with taskId = {task_id}")
 
   def get_py_executor(self, forced_command_name):
     """

ambari-agent/src/main/python/ambari_agent/DataCleaner.py

@@ -44,7 +44,7 @@ def __init__(self, config):
     self.file_max_age = config.get("agent", "data_cleanup_max_age", 86400)
     self.file_max_age = int(self.file_max_age) if self.file_max_age else None
     if self.file_max_age is None or self.file_max_age < 86400:  # keep for at least 24h
-      logger.warn(
+      logger.warning(
         "The minimum value allowed for data_cleanup_max_age is 1 "
         "day. Setting data_cleanup_max_age to 86400."
       )
@@ -57,7 +57,7 @@ def __init__(self, config):
     if (
       self.cleanup_interval is None or self.cleanup_interval < 3600
     ):  # wait at least 1 hour between runs
-      logger.warn(
+      logger.warning(
         "The minimum value allowed for data_cleanup_interval is 1 "
         "hour. Setting data_cleanup_interval to 3600."
       )
@@ -70,7 +70,7 @@ def __init__(self, config):
     if (
       self.cleanup_max_size_MB is None or self.cleanup_max_size_MB > 10000
     ):  # no more than 10 GBs
-      logger.warn(
+      logger.warning(
         "The maximum value allowed for cleanup_max_size_MB is 10000 MB (10 GB). "
         "Setting cleanup_max_size_MB to 10000."
       )
@@ -132,7 +132,7 @@ def cleanup(self):
           pass
       else:
         # Did not reach below cap.
-        logger.warn(
+        logger.warning(
           "DataCleaner deleted an additional %d files, currently log files occupy %d bytes."
           % (count, total_size_bytes)
         )

ambari-agent/src/main/python/ambari_agent/Facter.py

@@ -74,7 +74,7 @@ def resolve_ambari_config(self):
         raise Exception("No config found, use default")
 
     except Exception as err:
-      log.warn(err)
+      log.warning(err)
     return config
 
   # Return first ip adress
@@ -200,7 +200,7 @@ def getSystemResourceOverrides(self):
                 for key, value in data.items():
                   systemResources[key] = data[key]
           except:
-            log.warn(
+            log.warning(
               f"Cannot read values from json files in {systemResourceDir}. it won't be used for gathering system resources."
             )
         else:
@@ -308,7 +308,7 @@ def getUptimeSeconds(self):
       )
       return int(result)
     except:
-      log.warn("Can not get SwapFree")
+      log.warning("Can not get SwapFree")
     return 0
 
   # Return memoryfree
@@ -323,7 +323,7 @@ def getMemoryFree(self):
       )
       return result
     except:
-      log.warn("Can not get MemoryFree")
+      log.warning("Can not get MemoryFree")
     return 0
 
   # Return memorytotal
@@ -338,7 +338,7 @@ def getMemoryTotal(self):
       )
       return result
     except:
-      log.warn("Can not get MemoryTotal")
+      log.warning("Can not get MemoryTotal")
     return 0
 
   # Return swapfree
@@ -353,7 +353,7 @@ def getSwapFree(self):
       )
       return result
     except:
-      log.warn("Can not get SwapFree")
+      log.warning("Can not get SwapFree")
     return 0
 
   # Return swapsize
@@ -368,7 +368,7 @@ def getSwapSize(self):
       )
       return result
     except:
-      log.warn("Can not get SwapFree")
+      log.warning("Can not get SwapFree")
     return 0
 
   # Return memorysize
@@ -383,7 +383,7 @@ def getMemorySize(self):
       )
       return result
     except:
-      log.warn("Can not get MemorySize")
+      log.warning("Can not get MemorySize")
     return 0
 
   def facterInfo(self):
@@ -437,7 +437,7 @@ def setDataIfConfigShortOutput():
       return_code, stdout, stderr = run_os_command(FacterLinux.GET_IFCONFIG_SHORT_CMD)
       return stdout
     except OSError:
-      log.warn(f"Can't execute {FacterLinux.GET_IFCONFIG_SHORT_CMD}")
+      log.warning(f"Can't execute {FacterLinux.GET_IFCONFIG_SHORT_CMD}")
     return ""
 
   # Returns the output of `ip link` command
@@ -447,7 +447,7 @@ def setDataIpLinkOutput():
       return_code, stdout, stderr = run_os_command(FacterLinux.GET_IP_LINK_CMD)
       return stdout
     except OSError:
-      log.warn(f"Can't execute {FacterLinux.GET_IP_LINK_CMD}")
+      log.warning(f"Can't execute {FacterLinux.GET_IP_LINK_CMD}")
     return ""
 
   @staticmethod
@@ -456,7 +456,7 @@ def setDataUpTimeOutput():
       return_code, stdout, stderr = run_os_command(FacterLinux.GET_UPTIME_CMD)
       return stdout
     except OSError:
-      log.warn(f"Can't execute {FacterLinux.GET_UPTIME_CMD}")
+      log.warning(f"Can't execute {FacterLinux.GET_UPTIME_CMD}")
     return ""
 
   @staticmethod
@@ -465,7 +465,7 @@ def setMemInfoOutput():
       return_code, stdout, stderr = run_os_command(FacterLinux.GET_MEMINFO_CMD)
       return stdout
     except OSError:
-      log.warn(f"Can't execute {FacterLinux.GET_MEMINFO_CMD}")
+      log.warning(f"Can't execute {FacterLinux.GET_MEMINFO_CMD}")
     return ""
 
   # Returns the FQDN of the host
@@ -479,7 +479,7 @@ def isSeLinux(self):
       if se_status:
         return True
     except OSError:
-      log.warn(f"Could not run {FacterLinux.GET_SE_LINUX_ST_CMD}: OK")
+      log.warning(f"Could not run {FacterLinux.GET_SE_LINUX_ST_CMD}: OK")
     return False
 
   def return_first_words_from_list(self, list):
@@ -549,7 +549,7 @@ def get_ip_address_by_ifname(self, ifname):
         )[20:24]
       )
     except Exception as err:
-      log.warn(f"Can't get the IP address for {ifname}")
+      log.warning(f"Can't get the IP address for {ifname}")
 
     return ip_address_by_ifname
 
@@ -566,7 +566,7 @@ def getInterfaces(self):
     if result != "":
       return result
     # If the host has neither `ifocnfig` command nor `ip` command, then return "OS NOT SUPPORTED"
-    log.warn(
+    log.warning(
       f"Can't get a network interfaces list from {self.DATA_IFCONFIG_SHORT_OUTPUT}"
     )
     return "OS NOT SUPPORTED"
@@ -578,7 +578,7 @@ def getUptimeSeconds(self):
         self.data_return_first(FacterLinux.DIGITS_REGEXP, self.DATA_UPTIME_OUTPUT)
       )
     except ValueError:
-      log.warn(f"Can't get an uptime value from {self.DATA_UPTIME_OUTPUT}")
+      log.warning(f"Can't get an uptime value from {self.DATA_UPTIME_OUTPUT}")
       return 0
 
   # Return memoryfree
@@ -589,7 +589,7 @@ def getMemoryFree(self):
         self.data_return_first(FacterLinux.FREEMEM_REGEXP, self.DATA_MEMINFO_OUTPUT)
       )
     except ValueError:
-      log.warn(f"Can't get free memory size from {self.DATA_MEMINFO_OUTPUT}")
+      log.warning(f"Can't get free memory size from {self.DATA_MEMINFO_OUTPUT}")
       return 0
 
   # Return memorytotal
@@ -599,7 +599,7 @@ def getMemoryTotal(self):
         self.data_return_first(FacterLinux.TOTALMEM_REGEXP, self.DATA_MEMINFO_OUTPUT)
       )
     except ValueError:
-      log.warn(f"Can't get total memory size from {self.DATA_MEMINFO_OUTPUT}")
+      log.warning(f"Can't get total memory size from {self.DATA_MEMINFO_OUTPUT}")
       return 0
 
   # Return swapfree
@@ -610,7 +610,7 @@ def getSwapFree(self):
         self.data_return_first(FacterLinux.SWAPFREE_REGEXP, self.DATA_MEMINFO_OUTPUT)
       )
     except ValueError:
-      log.warn(f"Can't get free swap memory size from {self.DATA_MEMINFO_OUTPUT}")
+      log.warning(f"Can't get free swap memory size from {self.DATA_MEMINFO_OUTPUT}")
       return 0
 
   # Return swapsize
@@ -621,7 +621,7 @@ def getSwapSize(self):
         self.data_return_first(FacterLinux.SWAPTOTAL_REGEXP, self.DATA_MEMINFO_OUTPUT)
       )
     except ValueError:
-      log.warn(f"Can't get total swap memory size from {self.DATA_MEMINFO_OUTPUT}")
+      log.warning(f"Can't get total swap memory size from {self.DATA_MEMINFO_OUTPUT}")
       return 0
 
   # Return memorysize
@@ -632,7 +632,7 @@ def getMemorySize(self):
         self.data_return_first(FacterLinux.TOTALMEM_REGEXP, self.DATA_MEMINFO_OUTPUT)
       )
     except ValueError:
-      log.warn(f"Can't get memory size from {self.DATA_MEMINFO_OUTPUT}")
+      log.warning(f"Can't get memory size from {self.DATA_MEMINFO_OUTPUT}")
       return 0
 
   def facterInfo(self):

ambari-agent/src/main/python/ambari_agent/FileCache.py

@@ -212,7 +212,7 @@ def provide_directory(self, cache_path, subdirectory, server_url_prefix):
             self.write_hash_sum(full_path, remote_hash)
             logger.info(f"Updated directory {full_path}")
           else:
-            logger.warn(
+            logger.warning(
               "Skipping empty archive: {0}. "
               "Expected archive was not found. Cached copy will be used.".format(
                 download_url
@@ -224,7 +224,7 @@ def provide_directory(self, cache_path, subdirectory, server_url_prefix):
     except CachingException as e:
       if self.tolerate_download_failures:
         # ignore
-        logger.warn(
+        logger.warning(
           "Error occurred during cache update. "
           "Error tolerate setting is set to true, so"
           " ignoring this error and continuing with current cache. "

ambari-agent/src/main/python/ambari_agent/Hardware.py

@@ -184,7 +184,7 @@ def osdisks(self):
       )
       dfdata = out
     except Exception as ex:
-      logger.warn("Checking disk usage failed: " + str(ex))
+      logger.warning("Checking disk usage failed: " + str(ex))
       dfdata = ""
 
     result_mounts = []

ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py

@@ -330,7 +330,7 @@ def presend_hook(correlation_id):
       )
     except ConnectionIsAlreadyClosed:
       # this happens when trying to connect to broken connection. Happens if ambari-server is restarted.
-      logger.warn(f"Connection failed while trying to connect to {destination}")
+      logger.warning(f"Connection failed while trying to connect to {destination}")
       raise
 
     try: