Skip to content

Commit 64ac082

Browse files
DaanHooglandDaan Hooglandsureshanaparti
authored
merge conflict fixes (#13046)
* merge conflict fixes * fix pre-commit issue Co-authored-by: Daan Hoogland <dahn@apache.org> Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
1 parent be89e6f commit 64ac082

4 files changed

Lines changed: 3 additions & 11 deletions

File tree

agent/conf/agent.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,4 +472,3 @@ iscsi.session.cleanup.enabled=false
472472
# Optional vCenter SHA1 thumbprint for VMware to KVM conversion via VDDK, passed as
473473
# -io vddk-thumbprint=<value>. If unset, CloudStack computes it on the KVM host via openssl.
474474
#vddk.thumbprint=
475-

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtConvertInstanceCommandWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public Answer execute(ConvertInstanceCommand cmd, LibvirtComputingResource serve
107107
String vddkLibDir = resolveVddkSetting(cmd.getVddkLibDir(), serverResource.getVddkLibDir());
108108
if (StringUtils.isBlank(vddkLibDir)) {
109109
String err = String.format("VDDK lib dir is not configured on the host. " +
110-
"Set '%s' in agent.properties or in details parameter of the import api calll to use VDDK-based conversion.", "vddk.lib.dir");
110+
"Set '%s' in agent.properties or in details parameter of the import api call to use VDDK-based conversion.", "vddk.lib.dir");
111111
logger.error("({}) {}", originalVMName, err);
112112
return new Answer(cmd, false, err);
113113
}

server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1325,10 +1325,7 @@ private UserVmResponse baseImportInstance(ImportUnmanagedInstanceCmd cmd) {
13251325
List<String> managedVms = new ArrayList<>(additionalNameFilters);
13261326
managedVms.addAll(getHostsManagedVms(hosts));
13271327

1328-
List<String> resourceLimitHostTags = resourceLimitService.getResourceLimitHostTags(serviceOffering, template);
1329-
try (CheckedReservation vmReservation = new CheckedReservation(owner, Resource.ResourceType.user_vm, resourceLimitHostTags, 1L, reservationDao, resourceLimitService);
1330-
CheckedReservation cpuReservation = new CheckedReservation(owner, Resource.ResourceType.cpu, resourceLimitHostTags, Long.valueOf(serviceOffering.getCpu()), reservationDao, resourceLimitService);
1331-
CheckedReservation memReservation = new CheckedReservation(owner, Resource.ResourceType.memory, resourceLimitHostTags, Long.valueOf(serviceOffering.getRamSize()), reservationDao, resourceLimitService)) {
1328+
try {
13321329

13331330
ActionEventUtils.onStartedActionEvent(userId, owner.getId(), EventTypes.EVENT_VM_IMPORT,
13341331
cmd.getEventDescription(), null, null, true, 0);
@@ -2673,10 +2670,7 @@ private UserVmResponse importKvmInstance(ImportVmCmd cmd) {
26732670

26742671
UserVm userVm = null;
26752672

2676-
List<String> resourceLimitHostTags = resourceLimitService.getResourceLimitHostTags(serviceOffering, template);
2677-
try (CheckedReservation vmReservation = new CheckedReservation(owner, Resource.ResourceType.user_vm, resourceLimitHostTags, 1L, reservationDao, resourceLimitService);
2678-
CheckedReservation cpuReservation = new CheckedReservation(owner, Resource.ResourceType.cpu, resourceLimitHostTags, Long.valueOf(serviceOffering.getCpu()), reservationDao, resourceLimitService);
2679-
CheckedReservation memReservation = new CheckedReservation(owner, Resource.ResourceType.memory, resourceLimitHostTags, Long.valueOf(serviceOffering.getRamSize()), reservationDao, resourceLimitService)) {
2673+
try {
26802674

26812675
if (ImportSource.EXTERNAL == importSource) {
26822676
String username = cmd.getUsername();

server/src/test/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImplTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,6 @@ public class UnmanagedVMsManagerImplTest {
260260
ImportVMTaskVO importVMTaskVO;
261261
@Mock
262262
private VMInstanceDetailsDao vmInstanceDetailsDao;
263-
264263
@Mock
265264
private ConfigKey<Boolean> configKeyMockParamsAllowed;
266265
@Mock

0 commit comments

Comments
 (0)