SSH key pairs are very buggy

[Matrix89]

problem

Having the ssh key pairs being identified by their name leads to a lot of weird issues.

1. The key pair validator allows commas(and other special characters like an ampersand) in the key pair name.
2. The deployVirtualMachine command keypairs parameter isn't escaped, this breaks on key pairs containing commas.
3. The deployVirtualMachine command keypair works with commas
4. The UI breaks when a key pair contains commas, below is a single key containing a bunch of commas
5. If the API consumer assumes the key pair name is safe and validated by cloudstack it cloud lead to a command injection(but it requires a lot of wrong assumptions)

versions

CloudStack 4.22.0.0

The steps to reproduce the bug

You can use the UI to observe most of the issues:

1. Create a new key pair with a comma in the name eg. test, test
2. Try creating a new instance with said key

What to do about it?

1. Add a new keypairId array parameter to all the endpoint which access key pair name.
2. Mark the keypair and keypairs parameters deprecated.

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template!

[kiranchavala]

Thanks @Matrix89 was able to reproduce the issue

We need to add a validation for the following api call

https://cloudstack.apache.org/api/apidocs-4.22/apis/createSSHKeyPair.html
https://cloudstack.apache.org/api/apidocs-4.22/apis/registerSSHKeyPair.html

1. Created a sshkeypair with name "test,test"

2. Exception when trying to launch a vm from the ui

3. Depploy a vm from the api call

deploy virtualmachine templateid=51f036c4-2137-11f1-b16a-1e00190002a8 serviceofferingid=327f7a0e-6080-4db3-a861-8ad8de72c6f3 networkids=d67ca7ca-1022-4653-a15c-3f009bca48af keypair=test,test zoneid=b8f183d0-a866-4619-a3e2-dc0ea05c665f

4. Check the ui