Skip to content

Commit 2474104

Browse files
committed
Add more key memory accounting
1 parent 0b43242 commit 2474104

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

datafusion/execution/src/cache/cache_unit.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,16 +103,18 @@ impl DefaultFileStatisticsCacheState {
103103
let entry_size = value.heap_size();
104104

105105
if entry_size + key_size > self.memory_limit {
106-
// Remove stale entry if exists
106+
// Remove potential stale entry
107107
self.remove(key);
108108
return None;
109109
}
110110

111111
let old_value = self.lru_queue.put(key.clone(), value);
112-
self.memory_used += entry_size + key_size;
112+
self.memory_used += entry_size;
113113

114114
if let Some(old_entry) = &old_value {
115115
self.memory_used -= old_entry.heap_size();
116+
} else {
117+
self.memory_used += key.heap_size();
116118
}
117119

118120
self.evict_entries();

0 commit comments

Comments
 (0)