skip on pessimistic mode only

Author: PawelSuwinski

src/create/CreateGuesser.tsx

@@ -52,6 +52,7 @@ export const IntrospectedCreateGuesser = ({
   schema,
   schemaAnalyzer,
   resource,
+  mutationMode = 'pessimistic',
   mutationOptions,
   redirect: redirectTo = 'list',
   mode,
@@ -70,6 +71,7 @@ export const IntrospectedCreateGuesser = ({
     resource,
     schemaAnalyzer,
     fields,
+    mutationMode,
     mutationOptions,
     transform,
     redirectTo,

src/edit/EditGuesser.tsx

@@ -76,6 +76,7 @@ export const IntrospectedEditGuesser = ({
     schemaAnalyzer,
     fields,
     mutationOptions,
+    mutationMode,
     transform,
     redirectTo,
     children: [],

src/types.ts

@@ -525,4 +525,5 @@ export type UseOnSubmitProps = Pick<
   'schemaAnalyzer' | 'resource' | 'fields'
 > &
   Pick<CreateProps, 'mutationOptions' | 'transform'> &
-  PickRename<CreateProps, 'redirect', 'redirectTo'>;
+  PickRename<CreateProps, 'redirect', 'redirectTo'> &
+  Partial<Pick<EditProps, 'mutationMode'>>;

src/useOnSubmit.test.tsx

@@ -5,6 +5,7 @@ import { render, waitFor } from '@testing-library/react';
 import {
   type CreateResult,
   DataProviderContext,
+  type MutationMode,
   type RaRecord,
   type UpdateResult,
   testDataProvider,
@@ -142,9 +143,15 @@ test.each([
   });
 });
 
-test.each([{ name: 'Required' }, null])(
-  'notification handling on validation errors (%s)',
-  async (submissionErrors) => {
+test.each`
+  submissionErrors        | mutationMode     | shouldNotify
+  ${{ name: 'Required' }} | ${'pessimistic'} | ${false}
+  ${{ name: 'Required' }} | ${'optimistic'}  | ${true}
+  ${{ name: 'Required' }} | ${'undoable'}    | ${true}
+  ${null}                 | ${'pessimistic'} | ${true}
+`(
+  'notification handling on validation errors ($submissionErrors, $mutationMode)',
+  async ({ submissionErrors, mutationMode, shouldNotify }) => {
     const { default: useOnSubmit } = await import('./useOnSubmit.js');
     notify.mockClear();
     dataProvider.create = jest.fn(() =>
@@ -155,6 +162,7 @@ test.each([{ name: 'Required' }, null])(
     const Dummy = () => {
       const onSubmit = useOnSubmit({
         ...onSubmitProps,
+        mutationMode: mutationMode as MutationMode,
         schemaAnalyzer: {
           ...onSubmitProps.schemaAnalyzer,
           getSubmissionErrors: () => submissionErrors,
@@ -182,7 +190,7 @@ test.each([{ name: 'Required' }, null])(
     await waitFor(() => {
       expect(dataProvider.create).toHaveBeenCalled();
     });
-    (submissionErrors ? expect(notify).not : expect(notify)).toHaveBeenCalled();
+    (shouldNotify ? expect(notify) : expect(notify).not).toHaveBeenCalled();
     expect(errors).toEqual(submissionErrors ?? {});
   },
 );

src/useOnSubmit.ts

@@ -21,6 +21,7 @@ const useOnSubmit = ({
   schemaAnalyzer,
   fields,
   mutationOptions,
+  mutationMode = 'pessimistic',
   transform,
   redirectTo = 'list',
 }: UseOnSubmitProps): ((
@@ -93,7 +94,7 @@ const useOnSubmit = ({
           mutationOptions?.onError ??
           ((error: string | Error) => {
             // Notification will be handled by the useNotifyIsFormInvalid hook.
-            if (submissionErrors) {
+            if (submissionErrors && mutationMode === 'pessimistic') {
               return;
             }
             const message =
@@ -125,6 +126,7 @@ const useOnSubmit = ({
     [
       fields,
       id,
+      mutationMode,
       mutationOptions,
       notify,
       redirect,