From f534028abec2a55586fc561afd3b49e3dff9694b Mon Sep 17 00:00:00 2001 From: Fazle Rabbi Sarker Date: Tue, 15 Sep 2026 11:19:51 +0600 Subject: [PATCH] Remove dead cmd/build-image call from opensearch workflows The opensearch and opensearch-dashboards images are built and pushed entirely by upstream's build-image-multi-arch.sh (which downloads the released tarball by version) followed by 'crane cp' for the dated tag. The trailing 'go run cmd/build-image/main.go --name=opensearch...' line never did anything useful and always failed the job: 1. It runs from inside opensearch-build/docker/release (the script cd'd there), so the relative path resolves to nothing: Error: stat cmd/build-image/main.go: no such file or directory 2. Even from the repo root it would panic: cmd/build-image reads library//app.json via FindBlock, but opensearch has no app.json (it was removed in dfef1b00e) because it does not use the tag-checkout + cherry-pick + docker-build flow that app.json describes. The image is already built/pushed before this line, so removing it makes the job report its true (green) status without changing any image output. Signed-off-by: Fazle Rabbi Sarker --- .github/workflows/build-opensearch-dashboards.yml | 1 - .github/workflows/build-opensearch.yml | 2 -- 2 files changed, 3 deletions(-) diff --git a/.github/workflows/build-opensearch-dashboards.yml b/.github/workflows/build-opensearch-dashboards.yml index bf4ef91c8..659dc5459 100644 --- a/.github/workflows/build-opensearch-dashboards.yml +++ b/.github/workflows/build-opensearch-dashboards.yml @@ -109,7 +109,6 @@ jobs: ./build-image-multi-arch.sh -v ${{ matrix.tag }} -f $DOCKERFILE -p opensearch-dashboards -a "x64,arm64" -r "ghcr.io/appscode-images/daily/opensearch-dashboards" crane cp ghcr.io/appscode-images/daily/opensearch-dashboards:${{ matrix.tag }} ghcr.io/appscode-images/daily/opensearch-dashboards:${{ matrix.tag }}_$(date -u +'%Y%m%d') - go run cmd/build-image/main.go --name=opensearch-dashboards --tag=${{ matrix.tag }} # report: # name: Report diff --git a/.github/workflows/build-opensearch.yml b/.github/workflows/build-opensearch.yml index aa5da08f1..cc2e91f69 100644 --- a/.github/workflows/build-opensearch.yml +++ b/.github/workflows/build-opensearch.yml @@ -110,8 +110,6 @@ jobs: ./build-image-multi-arch.sh -v ${{ matrix.tag }} -f $DOCKERFILE -p opensearch -a "x64,arm64" -r "ghcr.io/appscode-images/daily/opensearch" crane cp ghcr.io/appscode-images/daily/opensearch:${{ matrix.tag }} ghcr.io/appscode-images/daily/opensearch:${{ matrix.tag }}_$(date -u +'%Y%m%d') - go run cmd/build-image/main.go --name=opensearch --tag=${{ matrix.tag }} - # report: # name: Report # runs-on: ubuntu-latest