Broad rename working

Author: gbro3n

TECHNICAL.md

@@ -1592,7 +1592,16 @@ If `resolveAlias(oldPageName)` returns the same page whose filename is `oldPageN
 
 **Workspace-wide link update:**
 
-`updateLinksInWorkspace()` finds all `.md` and `.markdown` files, parses each for wikilinks, and creates a `WorkspaceEdit` that replaces every `[[oldPageName]]` with `[[newPageName]]`. After applying the edit, it saves modified files.
+`updateLinksInWorkspace()` finds all `.md` and `.markdown` files, parses each for wikilinks, and now uses a split write strategy:
+
+1. **Already-open documents** are updated through a `WorkspaceEdit` so their live editor buffers stay authoritative.
+2. **Closed documents** are rewritten directly on disk using `workspace.fs.writeFile()` after a raw `fs.readFile()` pass.
+
+This avoids VS Code opening newly-dirty tabs for files that were closed before the rename, which in turn avoids working-copy save conflicts on those reference files.
+
+**Index-driven candidate narrowing:**
+
+Rename refactors no longer have to discover rewrite candidates by scanning the entire workspace up front. `IndexService.findPagesLinkingToPageNames(...)` queries the `links` table for distinct source pages whose indexed `page_name` matches one of the renamed targets. `updateLinksInWorkspace()` now accepts those candidate URIs and only opens that bounded set of files when a candidate set is provided. The actual rewrite still parses the real file text before editing, so the index narrows the search space but does not become the edit source of truth.
 
 **Notification progress:**
 
@@ -1631,9 +1640,13 @@ This selection logic is isolated in `WikilinkExplorerMergeService.ts` so the amb
 The user-confirmed refactor work that follows explorer renames is now extracted into `WikilinkExplorerRenameRefactorService.ts`. That helper applies the same notification UX as in-editor renames:
 
 1. Accepted merge operations show `AS Notes: Applying rename updates` while the merge, delete, and target re-index complete.
-2. Accepted workspace-wide reference updates show `AS Notes: Updating wikilink references` while link replacement and stale-scan refresh complete.
+2. Accepted workspace-wide reference updates show `AS Notes: Updating wikilink references` while index-driven candidate rewrite and targeted file re-indexing complete.
 3. Declined explorer prompts do not show progress notifications.
 
+For explorer renames, the old broad `staleScan()` follow-up has been replaced with targeted re-indexing of the files actually edited by the refactor. That removes a second whole-tree pass from the common rename path.
+
+`updateLinksInWorkspace()` no longer auto-saves affected open editors after applying workspace edits. Instead, both the in-editor and explorer rename flows now use `reindexWorkspaceUri(...)`: if an affected file is currently open, it is re-indexed from the live editor buffer via `indexFileContent(...)`; otherwise it falls back to `indexScanner.indexFile(...)`. `WikilinkRenameTracker` still re-indexes the initiating document from `document.getText()` when its URI is stable, and remaps any old source candidate URI to the post-rename or post-merge target before follow-up indexing. Combined with the direct-to-disk rewrite path for closed files, this avoids save conflicts on both open reference files and files that were previously closed, as well as attempts to reopen a source file that has just been renamed or deleted.
+
 ### Re-entrancy guard
 
 The `isProcessing` flag prevents document-change events fired by the rename operation itself (file renames, workspace edits) from being treated as new user edits. It is set to `true` before any rename work begins and cleared in the `finally` block.

docs-src/docs/Backlinks.md

@@ -4,7 +4,7 @@ order: 3
 
 # Backlinks
 
-The Backlinks panel shows every note in your workspace that links to a given page. It is one of the most powerful navigation tools in AS Notes — use it to understand how ideas connect across your knowledge base.
+The Backlinks panel shows every note in your workspace that links to a given page. Use it to understand how ideas connect across your knowledge base.
 
 ## Opening the Panel
 
@@ -24,7 +24,7 @@ For example, if `Project.md` contains:
   - [[NGINX]]
 ```
 
-…then the backlink chain for `NGINX` from `Project.md` would be:
+… then the backlink chain for `NGINX` from `Project.md` would be:
 
 ```
 Project → Tasks → NGINX

docs-src/docs/Getting Started.md

@@ -8,7 +8,7 @@ This page gets you from zero to a working AS Notes workspace in a few minutes.
 
 ## 1. Install the Extension
 
-Install **AS Notes** from the [VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=appsoftwareltd.as-notes).
+Install **AS Notes** from [Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=appsoftwareltd.as-notes) / [Open VSX](https://open-vsx.org/extension/appsoftwareltd/as-notes)
 
 Open VS Code, go to the Extensions view (`Ctrl+Shift+X`), search for **AS Notes**, and click **Install**.
 
@@ -33,9 +33,9 @@ Look for the AS Notes sidebar icon to view Search, Calendar, Kanban Boards and T
 
 ## 4. Write Your First Note
 
-Create a new `.md` file and start writing. Type `[[` anywhere to trigger [[Wikilinks]] autocomplete - a list of all your pages appears immediately.
+Create a new `.md` file and start writing. Type `[[` anywhere to trigger [[Wikilinks]] autocomplete - a list of all your pages appears immediately (unless this is your first page and wikilink, in which case it will be added too the index ready for referencing).
 
-Try adding a task `- [ ] task text` and try toggling the task state from the task management side panel.
+Next, try adding a task `- [ ] task text` (`Ctrl+Shift+Enter` / `Cmd+Shift+Enter`) and try toggling the task state from the task management side panel or by clicking the check box or by cycling the keyboard shortcut.
 
 ## Excluding Files from the Index
 
@@ -62,8 +62,8 @@ If the index ever becomes stale or corrupted, run **AS Notes: Rebuild Index** fr
 
 ## Cleaning the Workspace
 
-If the extension is in a bad state (e.g. persistent errors after a crash), run **AS Notes: Clean Workspace** to remove the `.asnotes/` directory and reset all in-memory state. Your `.asnotesignore` file is preserved. Run **AS Notes: Initialise Workspace** afterwards to start fresh.
+Run **AS Notes: Clean Workspace** to remove the `.asnotes/` directory and reset all in-memory state. Your `.asnotesignore` file is preserved. Run **AS Notes: Initialise Workspace** afterwards to start fresh.
 
 ## Compatibility With Other Tools
 
-AS Notes workspaces are plain markdown files in plain folders - they are compatible with Obsidian and Logseq due to similar file structures. Be aware there are format and behavioural differences, but you can use the same notes folder with multiple tools.
+AS Notes workspaces are plain markdown files in plain folders - they are largely compatible with Obsidian and Logseq due to similar file structures. Be aware there are format and behavioural differences, but you can use the same notes folder with multiple tools.

docs-src/docs/index.md

@@ -8,11 +8,10 @@ AS Notes brings markdown and [[wikilink]] editing for notes, documentation, blog
 
 **Capture ideas, link concepts, write, and stay focused - without ever leaving your editor.**
 
-> **This documentation was written and generated using AS Notes. See [[Publishing a Static Site]] for how you can use AS Notes for your docs, including deploying to GitHub Pages**.
+> **This documentation was written and generated using AS Notes. See [[Publishing a Static Site]] for how you can use AS Notes for your docs, including deploying to GitHub Pages, Cloudflare and More**.
 
-> **Install:** [https://marketplace.visualstudio.com/items?itemName=appsoftwareltd.as-notes](https://marketplace.visualstudio.com/items?itemName=appsoftwareltd.as-notes)
-
-> **GitHub:** [https://github.com/appsoftwareltd/as-notes](https://github.com/appsoftwareltd/as-notes)
+> **Install:** [Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=appsoftwareltd.as-notes) / [Open VSX](https://open-vsx.org/extension/appsoftwareltd/as-notes)
+> **GitHub:** [github.com/appsoftwareltd/as-notes](https://github.com/appsoftwareltd/as-notes)
 
 ![AS Notes editor screenshot](../assets/images/as-notes-editor-screenshot.png)
 
@@ -22,13 +21,12 @@ If you've already installed AS Notes and want to get started, see [[Getting Star
 
 ## Why VS Code?
 
-Using VS Code as your notes app gives you a huge amount for free before you even start using AS Notes features:
+Using VS Code as your notes app gives you a huge amount for free in addition the features that AS Notes provides:
 
-- Cross-platform and web-based (via VS Code Workspaces)
+- Cross-platform compatibility and web access (via VS Code Workspaces)
 - Tabs, file explorer, themes, keyboard shortcuts
-- A vast extension library — Mermaid diagrams, Vim mode, and more, all usable alongside AS Notes
+- A vast extension library
 - AI chat (GitHub Copilot, Claude, etc.) to query and work with your notes
-- Outliner-style indentation via `Ctrl+[` / `Ctrl+]`
 - Syntax highlighting for code embedded in your notes
 
 ## Features at a Glance
@@ -65,4 +63,4 @@ AS Notes is privacy-first. It never connects to external servers. All indexing,
 
 ## Licence
 
-See [[Licence Rationale]] for an explanation of the source-available licence model.
+See [[Licence]]

vs-code-extension/src/IndexService.ts

@@ -570,6 +570,34 @@ export class IndexService {
         return this.mapLinkRows(result[0].values);
     }
 
+    /**
+     * Find distinct source pages containing links to any of the supplied page names.
+     * Used to narrow rename refactors to only files that could contain matches.
+     */
+    findPagesLinkingToPageNames(pageNames: string[]): PageRow[] {
+        this.ensureOpen();
+        if (pageNames.length === 0) { return []; }
+
+        const placeholders = pageNames.map(() => '?').join(', ');
+        const result = this.db!.exec(
+            `SELECT DISTINCT p.id, p.path, p.filename, p.title, p.mtime, p.indexed_at
+             FROM pages p
+             JOIN links l ON l.source_page_id = p.id
+             WHERE l.page_name IN (${placeholders})
+             ORDER BY p.path COLLATE NOCASE`,
+            pageNames,
+        );
+        if (result.length === 0) { return []; }
+        return result[0].values.map(row => ({
+            id: row[0] as number,
+            path: row[1] as string,
+            filename: row[2] as string,
+            title: row[3] as string,
+            mtime: row[4] as number,
+            indexed_at: row[5] as number,
+        }));
+    }
+
     /**
      * Get the total number of links across all pages.
      * Uses a single `COUNT(*)` query — O(1) regardless of table size.

vs-code-extension/src/WikilinkExplorerRenameRefactorService.ts

@@ -8,7 +8,7 @@ import {
     pickUniqueExplorerMergeTarget,
 } from './WikilinkExplorerMergeService.js';
 import { toNotesRelativePath } from './NotesRootService.js';
-import { updateLinksInWorkspace } from './WikilinkRefactorService.js';
+import { reindexWorkspaceUri, updateLinksInWorkspace } from './WikilinkRefactorService.js';
 import { withWikilinkRenameProgress } from './WikilinkRenameProgressService.js';
 
 interface ExplorerRenameFile {
@@ -20,7 +20,7 @@ interface ExplorerRenameRefactorDeps {
     files: ExplorerRenameFile[];
     renameTrackerIsRenaming: boolean;
     wikilinkService: WikilinkService;
-    indexService: Pick<IndexService, 'findPagesByFilename' | 'removePage'>;
+    indexService: Pick<IndexService, 'findPagesByFilename' | 'removePage' | 'findPagesLinkingToPageNames' | 'indexFileContent'>;
     indexScanner: Pick<IndexScanner, 'staleScan' | 'indexFile'>;
     notesRootPath?: string;
     safeSaveToFile: () => boolean;
@@ -95,12 +95,13 @@ export async function handleExplorerRenameRefactors({
                 );
                 edit.replace(targetUri, fullRange, mergedContent);
                 await vscode.workspace.applyEdit(edit);
-                await targetDoc.save();
 
                 progress.report('Refreshing index');
                 await vscode.workspace.fs.delete(newUri);
                 indexService.removePage(newPath);
-                try { await indexScanner.indexFile(targetUri); } catch { /* best effort */ }
+                try {
+                    await reindexWorkspaceUri(targetUri, { indexService, indexScanner, notesRootPath });
+                } catch { /* best effort */ }
                 safeSaveToFile();
             });
         }
@@ -130,11 +131,31 @@ export async function handleExplorerRenameRefactors({
     if (choice !== 'Yes') { return; }
 
     await withWikilinkRenameProgress('AS Notes: Updating wikilink references', async (progress) => {
+        const rootUri = notesRootPath
+            ? vscode.Uri.file(notesRootPath)
+            : vscode.workspace.workspaceFolders?.[0]?.uri;
+        const candidateUris = rootUri
+            ? indexService.findPagesLinkingToPageNames(linkRenames.map(rename => rename.oldPageName))
+                .map(page => vscode.Uri.joinPath(rootUri, page.path))
+            : [];
+
         progress.report('Updating links across workspace');
-        await updateLinksInWorkspace(wikilinkService, linkRenames);
+        const affectedUris = await updateLinksInWorkspace(
+            wikilinkService,
+            linkRenames,
+            candidateUris.length > 0 ? { candidateUris } : undefined,
+        );
 
         progress.report('Refreshing index');
-        try { await indexScanner.staleScan(); } catch { /* best effort */ }
+        for (const uri of affectedUris) {
+            try {
+                await reindexWorkspaceUri(uri, {
+                    indexService,
+                    indexScanner,
+                    notesRootPath,
+                });
+            } catch { /* best effort */ }
+        }
         if (safeSaveToFile()) {
             refreshProviders();
         }