FWClear is implemented only for eiger1 but it exists in Simplon 1.8.0

[ericonr]

The clear command is available as a FileWriter Command (section 5.3.4 of the reference), and I have tested it on our Pilatus4. Is there some reason it can't be exposed for Eiger2 and Pilatus4?

I believe this was the command that worked:

curl -X PUT -H "Content-Type: application/json" -d '{}' 10.31.71.19/filewriter/api/1.8.0/command/clear

Side question: why is it an ao record when device support uses asynInt32?

[MarkRivers]

I don't know why Clear was restricted to Eiger1 in the code. There is no indication of a reason in the commit history.

The fix is pretty easy:

• Move the code here so it is not just for API_1_6_0:

  ADEiger/eigerApp/src/eigerDetector.cpp

  Line 388 in 84b9392

  mFWClear = mParams.create(EigFWClearStr, asynParamInt32, SSFWCommand, "clear");

• Change the code here to remove the API_1_6_0 dependency:

  ADEiger/eigerApp/src/eigerDetector.cpp

  Line 519 in 84b9392

  else if (mAPIVersion == API_1_6_0 && function == mFWClear->getIndex())

• Move this record from Eiger1.template to EigerBase.template.

  ADEiger/eigerApp/Db/eiger1.template

  Line 61 in 84b9392

  record(ao, "$(P)$(R)FWClear") {

• Add the "Delete All" widgets to eiger2FileWriter.adl

It is fine for an ao record to use asynInt32 support. However, I think it would be more consistent to change this to a bo record.