Potential fix for code scanning alert no. 2: Hard-coded cryptographic value#191
Draft
arielsrv wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 2: Hard-coded cryptographic value#191arielsrv wants to merge 1 commit into
arielsrv wants to merge 1 commit into
Conversation
… value Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/arielsrv/rustapi/security/code-scanning/2
General fix: remove hard-coded password literals and generate per-call test passwords dynamically (or inject them via parameters/env), then hash as before.
Best minimal fix without changing existing functionality: in
src/tests/utils.rs, replace the hard-coded"Password1"with a generated password string derived from randomness/time so each created user gets a non-hardcoded credential while preserving the same flow (hash_password→User::new→User::create). Since we can only edit shown code and should avoid broad refactors, updatecreate_userlocally by generating a password at runtime (e.g., withSystemTimenanos), then pass it tohash_password.Needed changes:
src/tests/utils.rs, adduse std::time::{SystemTime, UNIX_EPOCH};.create_user, replacelet password = "Password1";with runtime-generatedString.Suggested fixes powered by Copilot Autofix. Review carefully before merging.