Skip to content

Commit 0534c06

Browse files
authored
Merge pull request #316 from brionmario/refactor-thunder-flows
fix: remove unnecessary loading state management from signInSilently
2 parents 7b277aa + cc90868 commit 0534c06

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

.changeset/chatty-crabs-agree.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@asgardeo/react': patch
3+
---
4+
5+
fix: remove unnecessary loading state management from signInSilently method

packages/react/src/AsgardeoReactClient.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -377,9 +377,7 @@ class AsgardeoReactClient<T extends AsgardeoReactConfig = AsgardeoReactConfig> e
377377
}
378378

379379
override async signInSilently(options?: SignInOptions): Promise<User | boolean> {
380-
return this.withLoading(async () => {
381-
return this.asgardeo.signInSilently(options as Record<string, string | boolean>);
382-
});
380+
return this.asgardeo.signInSilently(options as Record<string, string | boolean>);
383381
}
384382

385383
override signOut(options?: SignOutOptions, afterSignOut?: (afterSignOutUrl: string) => void): Promise<string>;

0 commit comments

Comments
 (0)