Add detection when no routes match for times

Author: backspace

src/commands/times.rs

@@ -51,6 +51,7 @@ pub async fn handle_times_request(
     };
 
     let mut schedule_lines: Vec<(NaiveDateTime, String)> = Vec::new();
+    let mut route_matched = false;
 
     for route_schedule in &parsed_response.stop_schedule.route_schedules {
         let number_as_string;
@@ -72,6 +73,8 @@ pub async fn handle_times_request(
             continue;
         }
 
+        route_matched = true;
+
         for scheduled_stop in &route_schedule.scheduled_stops {
             let time = NaiveDateTime::parse_from_str(
                 &scheduled_stop.times.departure.estimated,
@@ -141,6 +144,13 @@ pub async fn handle_times_request(
         }
     }
 
+    if !route_matched {
+        response_text.push_str(&format!(
+            "No routes found matching {} at this stop",
+            command.routes.join(" ")
+        ));
+    }
+
     Ok(response_text)
 }
 

tests/times.rs

@@ -241,6 +241,46 @@ async fn stop_number_returns_single_route_ignoring_case(db: PgPool) {
     assert_that(body).contains(expected_body);
 }
 
+#[sqlx::test(fixtures("numbers-approved"))]
+async fn stop_number_notes_no_matching_routes(db: PgPool) {
+    let mock_winnipeg_transit_api = MockServer::start().await;
+    let mock_stop_schedule_response = fs::read_to_string("tests/fixtures/times/stop_schedule.json")
+        .expect("Failed to read stop schedule fixture");
+
+    Mock::given(method("GET"))
+        .and(path_regex(r"^/v4/stops/.*/schedule.json$"))
+        .respond_with(
+            ResponseTemplate::new(200).set_body_string(mock_stop_schedule_response.clone()),
+        )
+        .expect(1)
+        .mount(&mock_winnipeg_transit_api)
+        .await;
+
+    let response = get(
+        "/twilio?Body=10619 99&From=approved&To=textabus&MessageSid=SM1849",
+        InjectableServices {
+            db: db.clone(),
+            twilio_address: None,
+            winnipeg_transit_api_address: Some(mock_winnipeg_transit_api.uri()),
+        },
+    )
+    .await
+    .expect("Failed to execute request");
+
+    assert!(response.status().is_success());
+    assert_eq!(response.headers()["content-type"], "text/xml");
+
+    let document = Document::from(response.text().await.unwrap().as_str());
+    let body = &document.find(Name("body")).next().unwrap().text();
+
+    let expected_body = indoc! {"
+        10619 WB Graham@Vaughan (The Bay)
+        No routes found matching 99 at this stop
+        "};
+
+    assert_that(body).contains(expected_body);
+}
+
 #[sqlx::test(fixtures("numbers-approved"))]
 async fn incorrect_stop_number_returns_error(db: PgPool) {
     let mock_winnipeg_transit_api = MockServer::start().await;