Dependency Updater: Create env Before Commit Message (#501)

JenabaBa · web-flow · commit 8d4ecd9d9c16 · 2025-07-09T15:24:43.000-05:00
* chore: updated Updated dependencies for: reth => v1.5.1 (paradigmxyz/reth@v1.5.0...v1.5.1) * chore: updated Updated dependencies for: reth => v1.5.1 (paradigmxyz/reth@v1.5.0...v1.5.1) * view * change json * chore: updated Updated dependencies for: reth => v1.5.1 (paradigmxyz/reth@v1.5.0...v1.5.1) * m * fix order of creating env * test old version * chore: updated Updated dependencies for: reth => v1.5.1 (paradigmxyz/reth@v1.5.0...v1.5.1) * downgrade version * chore: updated Updated dependencies for: reth => v1.5.1 (paradigmxyz/reth@v1.5.0...v1.5.1) * undo sync * change function name
diff --git a/dependency_updater/dependency_updater.go b/dependency_updater/dependency_updater.go
@@ -116,18 +116,18 @@ func updater(token string, repoPath string, commit bool, githubAction bool) erro
 		}
 	}
 
+	e := createVersionsEnv(repoPath, dependencies)
+	if e != nil {
+		return fmt.Errorf("error creating versions.env: %s", e)
+	}
+
 	if (commit && updatedDependencies != nil) || (githubAction && updatedDependencies != nil) {
 		err := createCommitMessage(updatedDependencies, repoPath, githubAction)
 		if err != nil {
 			return fmt.Errorf("error creating commit message: %s", err)
 		}
 	}
 
-	e := createVersionsEnv(repoPath, dependencies)
-	if e != nil {
-		return fmt.Errorf("error creating versions.env: %s", e)
-	}
-
 	return nil
 }
 
@@ -273,15 +273,15 @@ func updateVersionTagAndCommit(
 	dependencies Dependencies) error {
 	dependencies[dependencyType].Tag = tag
 	dependencies[dependencyType].Commit = commit
-	err := writeToVersionsEnv(repoPath, dependencies)
+	err := writeToVersionsJson(repoPath, dependencies)
 	if err != nil {
 		return fmt.Errorf("error writing to versions "+dependencyType+": %s", err)
 	}
 
 	return nil
 }
 
-func writeToVersionsEnv(repoPath string, dependencies Dependencies) error {
+func writeToVersionsJson(repoPath string, dependencies Dependencies) error {
 	// formatting json
 	updatedJson, err := json.MarshalIndent(dependencies, "", "	  ")
 	print(dependencies["base_reth_node"].Branch)

Original file line number	Diff line number	Diff line change
`@@ -116,18 +116,18 @@ func updater(token string, repoPath string, commit bool, githubAction bool) erro`
`116`	`116`	`}`
`117`	`117`	`}`
`118`	`118`
	`119`	`+ e := createVersionsEnv(repoPath, dependencies)`
	`120`	`+ if e != nil {`
	`121`	`+ return fmt.Errorf("error creating versions.env: %s", e)`
	`122`	`+ }`
	`123`	`+`
`119`	`124`	`if (commit && updatedDependencies != nil) \|\| (githubAction && updatedDependencies != nil) {`
`120`	`125`	`err := createCommitMessage(updatedDependencies, repoPath, githubAction)`
`121`	`126`	`if err != nil {`
`122`	`127`	`return fmt.Errorf("error creating commit message: %s", err)`
`123`	`128`	`}`
`124`	`129`	`}`
`125`	`130`
`126`		`- e := createVersionsEnv(repoPath, dependencies)`
`127`		`- if e != nil {`
`128`		`- return fmt.Errorf("error creating versions.env: %s", e)`
`129`		`- }`
`130`		`-`
`131`	`131`	`return nil`
`132`	`132`	`}`
`133`	`133`
`@@ -273,15 +273,15 @@ func updateVersionTagAndCommit(`
`273`	`273`	`dependencies Dependencies) error {`
`274`	`274`	`dependencies[dependencyType].Tag = tag`
`275`	`275`	`dependencies[dependencyType].Commit = commit`
`276`		`- err := writeToVersionsEnv(repoPath, dependencies)`
	`276`	`+ err := writeToVersionsJson(repoPath, dependencies)`
`277`	`277`	`if err != nil {`
`278`	`278`	`return fmt.Errorf("error writing to versions "+dependencyType+": %s", err)`
`279`	`279`	`}`
`280`	`280`
`281`	`281`	`return nil`
`282`	`282`	`}`
`283`	`283`
`284`		`-func writeToVersionsEnv(repoPath string, dependencies Dependencies) error {`
	`284`	`+func writeToVersionsJson(repoPath string, dependencies Dependencies) error {`
`285`	`285`	`// formatting json`
`286`	`286`	`updatedJson, err := json.MarshalIndent(dependencies, "", " ")`
`287`	`287`	`print(dependencies["base_reth_node"].Branch)`