Skip to content

Commit 42bdab3

Browse files
committed
Improved checking for version specific arguments
1 parent 674db12 commit 42bdab3

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/WGet.NET/Components/WinGetPackageManager.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -808,12 +808,12 @@ public async Task<bool> UpgradeAllPackagesAsync()
808808

809809
private string AddArgumentByVersion(string argument)
810810
{
811-
// Checking version to determine if "--include-unknown" is necessary
812-
bool castSuccessful = int.TryParse(WinGetVersion.Split(".")[1], out int wingetMinorVersion);
813-
if (castSuccessful && wingetMinorVersion >= 4)
811+
// Checking version to determine if "--include-unknown" is necessary.
812+
Version winGetVersion = WinGetVersionObject;
813+
if (winGetVersion.Major >= 1 && winGetVersion.Minor >= 4)
814814
{
815815
// Winget version supports new argument, add "--include-unknown" to arguments
816-
argument += " " + _includeUnknown;
816+
argument += $" {_includeUnknown}";
817817
}
818818
return argument;
819819
}

0 commit comments

Comments
 (0)