From 1f388b4952632a41244794f4c0ccbad374257223 Mon Sep 17 00:00:00 2001 From: Simone Scarduzio Date: Thu, 10 Sep 2026 15:07:59 +0000 Subject: [PATCH 1/2] Take the bootstrap sweep off pull requests The matrix is 34 released versions x 2 envs, so it is 68 jobs. docs/dev/branching.md case 4 sends every workflow change to master. Three of them moved there today, and each queued its own 68 bootstrap jobs behind itself: approved, no failures, unmergeable for hours, while sweeping plugins that were released weeks ago. Every version in that matrix tests a plugin that is already out, so nothing a pull request changes can change the result. The nightly and a push to master still run it. Co-Authored-By: Claude Opus 5 --- .github/workflows/all-e2e-tests.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/all-e2e-tests.yml b/.github/workflows/all-e2e-tests.yml index d1994d5c..b5077fd1 100644 --- a/.github/workflows/all-e2e-tests.yml +++ b/.github/workflows/all-e2e-tests.yml @@ -99,11 +99,13 @@ jobs: # Bootstrap uses released images (no --mode), as it did before. master-bootstrap-tests: name: "🚀 Bootstrap Tests" + # Not on a pull request. The matrix is 34 released versions x 2 envs, and every one of them + # tests plugins that are already out, so nothing a pull request changes can change the result. + # The nightly and a push to master still run it, because the released set moves there. if: > github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || - (github.event_name == 'push' && github.ref == 'refs/heads/master') || - (github.event_name == 'pull_request' && github.base_ref == 'master' && github.event.pull_request.head.repo.fork == false) + (github.event_name == 'push' && github.ref == 'refs/heads/master') needs: prod-e2e-tests runs-on: ubuntu-latest strategy: From c5a94319751d26971ab452437254202839693b7c Mon Sep 17 00:00:00 2001 From: Simone Scarduzio Date: Sat, 12 Sep 2026 06:53:44 +0000 Subject: [PATCH 2/2] Also cancel a superseded pull-request run coutoPL's point on the review: a stale run can be cancelled instead. That is true and worth having, so it is here. It covers a different case, though. Cancelling helps when the same pull request is pushed twice. It does nothing for three open pull requests, which still queue their own bootstrap sweep each. Co-Authored-By: Claude Opus 5 --- .github/workflows/all-e2e-tests.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/all-e2e-tests.yml b/.github/workflows/all-e2e-tests.yml index b5077fd1..41aa4840 100644 --- a/.github/workflows/all-e2e-tests.yml +++ b/.github/workflows/all-e2e-tests.yml @@ -11,6 +11,14 @@ on: pull_request: types: [opened, synchronize, reopened] +# A second push to the same pull request makes the first run's result worthless, and this suite +# holds runners for hours. Cancel it. Only for pull requests: on master, the nightly and a manual +# dispatch the group is the run id, which is unique, so those runs neither cancel nor queue behind +# each other. Grouping them by ref instead would park a nightly behind a master push for hours. +concurrency: + group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.ref || github.run_id }} + cancel-in-progress: ${{ github.event_name == 'pull_request' }} + env: APPLY_RESOURCE_LIMITS: "auto"