Skip to content

Incorrect TypeScript Type Declaration for Controller in "@beyond-js/widgets" #1

@jircdev

Description

@jircdev

Description:

The TypeScript type declaration for the Controller class in "@beyond-js/widgets" seems to be missing the attributes property. When trying to access the attributes property on an instance of Controller, TypeScript throws an error:

Property 'attributes' does not exist on type 'Controller'.ts(2339)

However, when inspecting the generated JavaScript, the attributes property clearly exists on the Controller class.

Expected Behavior:

The attributes property should be correctly typed in the TypeScript declaration file for the Controller class.

Actual Behavior:

The TypeScript type declaration for the Controller class does not include the attributes property, resulting in a TypeScript error when trying to access it.

Steps to Reproduce:

  1. Create an instance or extend the Controller class from "@beyond-js/widgets".
  2. Try to access the attributes property.
  3. TypeScript error is thrown.

Recommendation:

Please adjust the TypeScript type declaration for the Controller class in "@beyond-js/widgets" to correctly include the attributes property. This will ensure that developers can confidently access and use this property without facing type errors.


I hope this helps! Let me know if you need any further adjustments.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions