Skip to content

A delay of 0 causes memory leak and page crash #19

Description

@parasshah195

On assuming that delay option means the initial time taken to start the counter, I changed it to 0 (not wanting any delay) after which the page started crashing every time the counter element came into view.

Realized that it was happening because the code does a division by delay here, meaning a division by 0 would cause a memory leak.

Ideally, the code should check and auto-assign the delay to a minimum of 1. And also, perhaps more clear instructions about the delay option in the readme would be helpful.

Thanks for creating this library.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions