Ensure metric terms are always communicated

Author: ZedThree

include/bout/coordinates.hxx

@@ -255,8 +255,6 @@ public:
     IntShiftTorsion_ = std::move(IntShiftTorsion);
   }
 
-  int communicateAndCheckMeshSpacing();
-
   ///////////////////////////////////////////////////////////
   // Parallel transforms
   ///////////////////////////////////////////////////////////

include/bout/metric_tensor.hxx

@@ -74,8 +74,6 @@ public:
     g23_m = function(g23_m);
   }
 
-  void communicate(Mesh* mesh);
-
 private:
   FieldMetric g11_m, g22_m, g33_m, g12_m, g13_m, g23_m;
 };

src/mesh/christoffel_symbols.cxx

@@ -8,8 +8,6 @@ ChristoffelSymbols::ChristoffelSymbols(Coordinates& coordinates) {
   // Note: This calculation is completely general: metric
   // tensor can be 2D or 3D. For 2D, all DDZ terms are zero
 
-  coordinates.communicateAndCheckMeshSpacing();
-
   const auto& contravariantMetricTensor = coordinates.getContravariantMetricTensor();
   const auto& covariantMetricTensor = coordinates.getCovariantMetricTensor();
 

src/mesh/coordinates.cxx

@@ -789,15 +789,6 @@ void Coordinates::setDz(FieldMetric dz) {
   localmesh->communicate(dz_);
 }
 
-int Coordinates::communicateAndCheckMeshSpacing() {
-  TRACE("Coordinates::communicateAndCheckMeshSpacing");
-
-  covariantMetricTensor.communicate(localmesh);
-  contravariantMetricTensor.communicate(localmesh);
-
-  return 0;
-}
-
 void Coordinates::recalculateAndReset(bool recalculate_staggered,
                                       bool force_interpolate_from_centre) {
 

src/mesh/metric_tensor.cxx

@@ -125,9 +125,6 @@ MetricTensor MetricTensor::inverse(const std::string& region) {
   output_info.write("\tMaximum error in off-diagonal inversion is {:e}\n",
                     off_diagonal_maxerr);
 
+  g_11.getMesh()->communicate(g_11, g_22, g_33, g_12, g_13, g_23);
   return MetricTensor(g_11, g_22, g_33, g_12, g_13, g_23);
 }
-
-void MetricTensor::communicate(Mesh* mesh) {
-  mesh->communicate(g11_m, g22_m, g33_m, g12_m, g13_m, g23_m);
-}