Skip to content

Commit f160bd3

Browse files
committed
6f_landau: I added some comments at the top of the files with some known issues of the model.
1 parent 5369fc4 commit f160bd3

1 file changed

Lines changed: 21 additions & 0 deletions

File tree

examples/6f_landau/6f_landau.cxx

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,27 @@
1212
* 3. for zonal field solver, hypre needed
1313
* */
1414

15+
/* Known issues with the 6-field model
16+
1) The ion parallel viscosity terms (enabled by parallel_viscous = true) have been
17+
implemented as full-f terms and not as perturbations. The background/equilibrium part
18+
has to be removed to make it consistent with the rest of the analysis. Doing so, might
19+
break the linear runs when we set nonlinear = false.
20+
2) The neutral model has been implemented as a full-f model. Many inconsistencies with the rest of the model and analysis.
21+
3) The landau heat flux closure has been removed.
22+
4) The sheath boundary conditions have been partially fixed. However, this breaks the linear
23+
runs when we set nonlinear = false. We will need to linearize the sound speed and heat fluxes for
24+
the linear runs, which will be done in the future.
25+
5) We apply BC on jpar after the sheath boundary conditions. This means that jpar takes BC from the input file.
26+
Unphysical values were observed when I applied sheath BC on jpar.
27+
6) We apply neumann BC on the potential phi in the parallel dir (sheath). Should we do something else?
28+
7) The auxiliary functions have not been tested when we migrated from v3 to v5. You may need to check if they are still correct.
29+
Older grid versions used to use different definitions for jysep1, jysep2, jysep1_2, jysep2_1 indexes.
30+
Different counting of y indexing was also for used to be used for double null cases.
31+
8) The zonal flow filed solver has not been tested.
32+
9) We use the phiSolver in the preconditioner and the constrains but the setCoef should be differnet there.
33+
We will need to difine a different instance of the Laplacian with different coeefficients for the preconditioner and constrains.
34+
*/
35+
1536
#include <cassert>
1637

1738
#include "bout/bout.hxx"

0 commit comments

Comments
 (0)