Skip to content

Commit 2e7a6c1

Browse files
paddymulclaude
andauthored
ci: consolidate ci.yml + build.yml into checks.yml (#533)
Merges both overlapping workflows into a single checks.yml file. Adds CheckDocs and TestJupyterLab as proper parallel jobs. Eliminates duplicate work that was running across both workflows. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3492d2e commit 2e7a6c1

2 files changed

Lines changed: 51 additions & 130 deletions

File tree

.github/workflows/build.yml

Lines changed: 0 additions & 114 deletions
This file was deleted.
Lines changed: 51 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: CI
1+
name: Checks
22
on:
33
push:
44
branches: [main]
@@ -240,6 +240,8 @@ jobs:
240240
name: Marimo Playwright Tests
241241
needs: [BuildWheel]
242242
runs-on: depot-ubuntu-latest
243+
timeout-minutes: 4
244+
continue-on-error: true
243245
steps:
244246
- uses: actions/checkout@v4
245247
- name: Install uv
@@ -274,11 +276,11 @@ jobs:
274276
- name: Run Marimo Playwright Tests
275277
run: bash scripts/test_playwright_marimo.sh
276278

277-
TestJupyterLab:
278-
name: JupyterLab Playwright Tests
279+
TestWASMMarimo:
280+
name: WASM Marimo Playwright Tests
279281
needs: [BuildWheel]
280282
runs-on: depot-ubuntu-latest
281-
timeout-minutes: 5
283+
timeout-minutes: 4
282284
continue-on-error: true
283285
steps:
284286
- uses: actions/checkout@v4
@@ -306,23 +308,53 @@ jobs:
306308
name: buckaroo-build
307309
- name: Install the project
308310
run: uv sync --all-extras --dev
309-
- name: Install built wheel and test dependencies
310-
run: |
311-
uv pip install --force-reinstall dist/*.whl
312-
uv pip install polars jupyterlab
313311
- name: Cache Playwright browsers
314312
uses: actions/cache@v4
315313
with:
316314
path: ~/.cache/ms-playwright
317315
key: playwright-${{ hashFiles('packages/buckaroo-js-core/package.json') }}
318-
- name: Run JupyterLab Playwright Tests
319-
run: bash scripts/test_playwright_jupyter.sh --venv-location=".venv"
316+
- name: Run WASM Marimo Playwright Tests
317+
run: bash scripts/test_playwright_wasm_marimo.sh
320318

321-
TestWASMMarimo:
322-
name: WASM Marimo Playwright Tests
319+
# ---------------------------------------------------------------------------
320+
# Docs — build documentation and check links
321+
# ---------------------------------------------------------------------------
322+
323+
CheckDocs:
324+
name: Docs / Build + Check Links
325+
runs-on: depot-ubuntu-latest
326+
timeout-minutes: 5
327+
steps:
328+
- uses: actions/checkout@v4
329+
- name: Install uv
330+
uses: astral-sh/setup-uv@v7
331+
with:
332+
enable-cache: true
333+
- uses: awalsh128/cache-apt-pkgs-action@latest
334+
with:
335+
packages: pandoc graphviz
336+
- name: Install the project
337+
run: uv sync --locked --all-extras --dev
338+
- name: Check docs build and links
339+
run: |
340+
mkdir -p buckaroo/static || true
341+
touch buckaroo/static/compiled.css
342+
touch buckaroo/static/widget.js
343+
touch buckaroo/static/widget.css
344+
mkdir -p docs/build/html
345+
uv run pytest --check-links docs/source/*.rst
346+
uv run pytest --check-links docs/example-notebooks/*.ipynb
347+
uv run sphinx-build -T -b html docs/source docs/build
348+
349+
# ---------------------------------------------------------------------------
350+
# JupyterLab integration tests
351+
# ---------------------------------------------------------------------------
352+
353+
TestJupyterLab:
354+
name: JupyterLab Playwright Tests
323355
needs: [BuildWheel]
324356
runs-on: depot-ubuntu-latest
325-
timeout-minutes: 4
357+
timeout-minutes: 10
326358
continue-on-error: true
327359
steps:
328360
- uses: actions/checkout@v4
@@ -349,11 +381,14 @@ jobs:
349381
with:
350382
name: buckaroo-build
351383
- name: Install the project
352-
run: uv sync --all-extras --dev
384+
run: |
385+
uv sync --all-extras --dev
386+
uv pip install --force-reinstall dist/*.whl
387+
uv pip install polars jupyterlab
353388
- name: Cache Playwright browsers
354389
uses: actions/cache@v4
355390
with:
356391
path: ~/.cache/ms-playwright
357392
key: playwright-${{ hashFiles('packages/buckaroo-js-core/package.json') }}
358-
- name: Run WASM Marimo Playwright Tests
359-
run: bash scripts/test_playwright_wasm_marimo.sh
393+
- name: Run JupyterLab Playwright Tests
394+
run: bash scripts/test_playwright_jupyter.sh --venv-location=".venv"

0 commit comments

Comments
 (0)