Skip to content

Commit ecccfd5

Browse files
paddymulclaude
andauthored
Fix marimo Playwright tests by displaying widgets as cell output (#531)
Widget cells used assignment statements as their last expression, but marimo only renders bare expressions as cell output. Adding the widget variable as a bare expression causes marimo to actually display the anywidget in the browser, which the Playwright tests depend on. Also removes continue-on-error and timeout-minutes from TestMarimo CI job now that the tests pass. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 867e8bc commit ecccfd5

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,6 @@ jobs:
240240
name: Marimo Playwright Tests
241241
needs: [BuildWheel]
242242
runs-on: depot-ubuntu-latest
243-
timeout-minutes: 4
244-
continue-on-error: true
245243
steps:
246244
- uses: actions/checkout@v4
247245
- name: Install uv

tests/notebooks/marimo_pw_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ def _(BuckarooWidget, pd):
3232
'score': [88.5, 92.3, 76.1, 95.0, 81.7],
3333
})
3434
small_widget = BuckarooWidget(small_df)
35+
small_widget
3536
return small_df, small_widget
3637

3738

@@ -48,6 +49,7 @@ def _(BuckarooInfiniteWidget, pd):
4849
rows.append({'id': i, 'value': i * 10, 'label': f'row_{i}'})
4950
large_df = pd.DataFrame(rows)
5051
large_widget = BuckarooInfiniteWidget(large_df)
52+
large_widget
5153
return large_df, rows, large_widget
5254

5355

0 commit comments

Comments
 (0)