Skip to content

Commit 541b383

Browse files
h3n4lclaude
andcommitted
test: strengthen assertions per review feedback
- Assert NumberInt("456") stores as int32(456), not just no-error - Assert NumberLong("1774250313") stores as int64(1774250313) - Insert in reverse order in pretty() sort test so assertion is meaningful Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 9c7c238 commit 541b383

2 files changed

Lines changed: 19 additions & 2 deletions

File tree

collection_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2270,9 +2270,10 @@ func TestPrettyNoOp(t *testing.T) {
22702270

22712271
ctx := context.Background()
22722272
collection := db.Client.Database(dbName).Collection("users")
2273+
// Insert in reverse alphabetical order so sort assertions are meaningful.
22732274
_, err := collection.InsertMany(ctx, []any{
2274-
bson.M{"name": "alice", "age": 30},
22752275
bson.M{"name": "bob", "age": 25},
2276+
bson.M{"name": "alice", "age": 30},
22762277
})
22772278
require.NoError(t, err)
22782279

@@ -2283,7 +2284,7 @@ func TestPrettyNoOp(t *testing.T) {
22832284
require.NoError(t, err)
22842285
require.Equal(t, 2, len(result.Value))
22852286

2286-
// pretty() chained after sort
2287+
// pretty() chained after sort — inserted bob first, sort should put alice first
22872288
result, err = gc.Execute(ctx, dbName, `db.users.find().sort({name: 1}).pretty()`)
22882289
require.NoError(t, err)
22892290
require.Equal(t, 2, len(result.Value))

internal/translator/bson_helpers_test.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,24 @@ func TestInt32StringArg(t *testing.T) {
229229
_, err = gc.Execute(ctx, dbName, `db.test.insertOne({val2: NumberInt("456")})`)
230230
require.NoError(t, err)
231231

232+
result, err = gc.Execute(ctx, dbName, `db.test.findOne({val2: {$exists: true}})`)
233+
require.NoError(t, err)
234+
require.Equal(t, 1, len(result.Value))
235+
doc, ok = result.Value[0].(bson.D)
236+
require.True(t, ok)
237+
val2 := getDocField(doc, "val2")
238+
require.Equal(t, int32(456), val2)
239+
232240
// NumberLong("1774250313") — from real user report
233241
_, err = gc.Execute(ctx, dbName, `db.test.insertOne({val3: NumberLong("1774250313")})`)
234242
require.NoError(t, err)
243+
244+
result, err = gc.Execute(ctx, dbName, `db.test.findOne({val3: {$exists: true}})`)
245+
require.NoError(t, err)
246+
require.Equal(t, 1, len(result.Value))
247+
doc, ok = result.Value[0].(bson.D)
248+
require.True(t, ok)
249+
val3 := getDocField(doc, "val3")
250+
require.Equal(t, int64(1774250313), val3)
235251
})
236252
}

0 commit comments

Comments
 (0)