From f143bc56f0a659bfecff0a8386ce6167d4343d42 Mon Sep 17 00:00:00 2001 From: Imani Pelton Date: Wed, 19 Aug 2026 09:11:16 -0400 Subject: [PATCH 1/4] fix(makefile): make pa11y-install idempotent --- docs/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Makefile b/docs/Makefile index d207fb9e..300f0faf 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -67,7 +67,7 @@ $(DOCS_VENVDIR): @touch $(DOCS_VENVDIR) pa11y-install: - @command -v $(PA11Y_CMD) >/dev/null || { \ + @command -v $(firstword $(PA11Y_CMD)) >/dev/null || { \ echo "Installing \"pa11y\" from npm..."; echo; \ mkdir -p $(DEV_DIR)/node_modules/ ; \ npm install --prefix $(DEV_DIR) pa11y; \ From e7e518ae2fc73d219390661484b2535fb57dcdec Mon Sep 17 00:00:00 2001 From: Imani Pelton Date: Thu, 20 Aug 2026 09:20:47 -0400 Subject: [PATCH 2/4] docs: add changelog entry --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0a20fe5e..30b69957 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,11 +5,12 @@ * Make removed URL check redirect-aware and add support for reusable workflow contexts * Exclude utility directories from builds and checks * Update link to documentation in README +* Skip pa11y installation if it is already present ### Changed * `docs/conf.py` [#610](https://github.com/canonical/sphinx-stack/pull/610) -* `docs/Makefile` [#605](https://github.com/canonical/sphinx-stack/pull/605), [#610](https://github.com/canonical/sphinx-stack/pull/610) +* `docs/Makefile` [#605](https://github.com/canonical/sphinx-stack/pull/605), [#610](https://github.com/canonical/sphinx-stack/pull/610), [#628](https://github.com/canonical/sphinx-stack/pull/628) * `README.md` [#603](https://github.com/canonical/sphinx-stack/pull/603) * `.github/workflows/cla-check.yml` [#606](https://github.com/canonical/sphinx-stack/pull/606) * `.github/workflows/check-removed-urls.yml` [#612](https://github.com/canonical/sphinx-stack/pull/#612) From 5cd9448eb3808779d66a93a814ce253621327682 Mon Sep 17 00:00:00 2001 From: Imani Pelton Date: Thu, 20 Aug 2026 09:21:00 -0400 Subject: [PATCH 3/4] chore: use test instead of command --- docs/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Makefile b/docs/Makefile index 300f0faf..263131e7 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -67,7 +67,7 @@ $(DOCS_VENVDIR): @touch $(DOCS_VENVDIR) pa11y-install: - @command -v $(firstword $(PA11Y_CMD)) >/dev/null || { \ + @test -x $(firstword $(PA11Y_CMD)) >/dev/null || { \ echo "Installing \"pa11y\" from npm..."; echo; \ mkdir -p $(DEV_DIR)/node_modules/ ; \ npm install --prefix $(DEV_DIR) pa11y; \ From 5c4203558cec3d1679015531e2920343f8d530e6 Mon Sep 17 00:00:00 2001 From: JJ Coldiron Date: Thu, 20 Aug 2026 10:40:24 -0700 Subject: [PATCH 4/4] docs: fix changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30b69957..eeba0855 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ ### Changed * `docs/conf.py` [#610](https://github.com/canonical/sphinx-stack/pull/610) -* `docs/Makefile` [#605](https://github.com/canonical/sphinx-stack/pull/605), [#610](https://github.com/canonical/sphinx-stack/pull/610), [#628](https://github.com/canonical/sphinx-stack/pull/628) +* `docs/Makefile` [#605](https://github.com/canonical/sphinx-stack/pull/605), [#610](https://github.com/canonical/sphinx-stack/pull/610), [#627](https://github.com/canonical/sphinx-stack/pull/627) * `README.md` [#603](https://github.com/canonical/sphinx-stack/pull/603) * `.github/workflows/cla-check.yml` [#606](https://github.com/canonical/sphinx-stack/pull/606) * `.github/workflows/check-removed-urls.yml` [#612](https://github.com/canonical/sphinx-stack/pull/#612)