`plot_availability()` example broken

[clayton33]

Current output for the plot_availiability() example code is

> plot_availability(areaType="station", areaName="P5", parameter="nitrate")
For stations, valid places for your selected parameters (i.e. nitrate) include:
Halifax, North Sydney, Yarmouth

For stations (specifically, P5) , valid parameters include:
sea_surface_height
Error in plot_availability(areaType = "station", areaName = "P5", parameter = "nitrate") : 
  Error: Bad areaName AND bad parameter

The output from that doesn't seem correct, as I don't think that sea_surface_height is actually available for station P5.

[casaultb]

Some things are really wrong here. Nitrate is available at stations other than those listed in the output (in fact, it is not available at the stations listed). Similarly, I concur that sea_surface_height is [likely] not available for P5. I am not really familiar with the function plot_availability(), some serious code review is required.

[clayton33]

I agree, I had a look at the code briefly, and I think we need to re-visit it at some point.

In the meantime, do agree that it's ok that we omit the area_indexer() and Temporally displaying data: plot_availability() sections from the search_azmpdata vignette for the time being ?

[casaultb]

That's fine with me. I wasn't involved in the development of these functions so it might take me some time to get things fixed.