fix: resolve database view find count and navigation regressions

Prevent non-visible views from dispatching lv-find-results which
overwrote the active view's match count in FindWidget. Fall back to
the raw field value in headless formatter when custom elements like
<call-stack> yield empty textContent in a detached element. Remove
lv-find-match from DMLView/SOQLView since DatabaseView orchestrates
match navigation via highlightIndex property binding. Fix SOQLView
dispatching db-find-results with type 'dml' instead of 'soql'. Add
disconnectedCallback to DatabaseView for listener cleanup.

Author: lukecotter

log-viewer/src/features/analysis/components/AnalysisView.ts

@@ -247,14 +247,14 @@ export class AnalysisView extends LitElement {
       this.totalMatches = result.totalMatches;
       this.findMap = result.matchIndexes;
 
-      if (!clearHighlights) {
+      if (!clearHighlights && isTableVisible) {
         document.dispatchEvent(
           new CustomEvent('lv-find-results', { detail: { totalMatches: result.totalMatches } }),
         );
       }
     }
 
-    if (this.totalMatches <= 0) {
+    if (this.totalMatches <= 0 || !isTableVisible) {
       return;
     }
     this.blockClearHighlights = true;

log-viewer/src/features/call-tree/components/CalltreeView.ts

@@ -395,15 +395,15 @@ export class CalltreeView extends LitElement {
       this.totalMatches = result.totalMatches;
       this.findMap = result.matchIndexes;
 
-      if (!clearHighlights) {
+      if (!clearHighlights && isTableVisible) {
         document.dispatchEvent(
           new CustomEvent('lv-find-results', { detail: { totalMatches: result.totalMatches } }),
         );
       }
     }
 
     // Highlight the current row and reset the previous or next depending on whether we are stepping forward or back.
-    if (this.totalMatches <= 0) {
+    if (this.totalMatches <= 0 || !isTableVisible) {
       return;
     }
     this.blockClearHighlights = true;

log-viewer/src/features/database/components/DMLView.ts

@@ -69,14 +69,12 @@ export class DMLView extends LitElement {
 
     document.addEventListener('lv-find', this._findEvt);
     document.addEventListener('lv-find-close', this._findEvt);
-    document.addEventListener('lv-find-match', this._findEvt);
   }
 
   disconnectedCallback(): void {
     super.disconnectedCallback();
     document.removeEventListener('lv-find', this._findEvt);
     document.removeEventListener('lv-find-close', this._findEvt);
-    document.removeEventListener('lv-find-match', this._findEvt);
   }
 
   updated(changedProperties: PropertyValues): void {
@@ -233,10 +231,6 @@ export class DMLView extends LitElement {
     }
 
     const newFindArgs = JSON.parse(JSON.stringify(e.detail));
-    if (!isTableVisible) {
-      newFindArgs.text = '';
-    }
-
     const newSearch =
       newFindArgs.text !== this.findArgs.text ||
       newFindArgs.options.matchCase !== this.findArgs.options?.matchCase;

log-viewer/src/features/database/components/DatabaseView.ts

@@ -45,6 +45,13 @@ export class DatabaseView extends LitElement {
     document.addEventListener('lv-find', this._findHandler as EventListener);
   }
 
+  disconnectedCallback(): void {
+    super.disconnectedCallback();
+    document.removeEventListener('db-find-results', this._findResults as EventListener);
+    document.removeEventListener('lv-find-match', this._findHandler as EventListener);
+    document.removeEventListener('lv-find', this._findHandler as EventListener);
+  }
+
   static styles = [
     globalStyles,
     css`

log-viewer/src/features/database/components/SOQLView.ts

@@ -80,14 +80,12 @@ export class SOQLView extends LitElement {
 
     document.addEventListener('lv-find', this._findEvt);
     document.addEventListener('lv-find-close', this._findEvt);
-    document.addEventListener('lv-find-match', this._findEvt);
   }
 
   disconnectedCallback(): void {
     super.disconnectedCallback();
     document.removeEventListener('lv-find', this._findEvt);
     document.removeEventListener('lv-find-close', this._findEvt);
-    document.removeEventListener('lv-find-match', this._findEvt);
   }
 
   updated(changedProperties: PropertyValues): void {
@@ -595,7 +593,7 @@ export class SOQLView extends LitElement {
 
     document.dispatchEvent(
       new CustomEvent('db-find-results', {
-        detail: { totalMatches: this.totalMatches, type: 'dml' },
+        detail: { totalMatches: this.totalMatches, type: 'soql' },
       }),
     );
   }

log-viewer/src/tabulator/module/Find.ts

@@ -513,18 +513,24 @@ export class Find extends Module {
       return String(value ?? '');
     }
 
+    // Fall back to the raw field value when the formatter result has no
+    // extractable text. This happens for custom-element HTML strings like
+    // <call-stack> whose content renders via shadow DOM — in a detached
+    // element they never connect, so textContent is empty.
+    const fallback = String(value ?? '');
+
     if (typeof result === 'string') {
       if (result.includes('<') && result.includes('>')) {
         const mockElem = this._mockSearchElem;
         mockElem.innerHTML = result;
         const text = mockElem.textContent ?? '';
         mockElem.textContent = '';
-        return text;
+        return text || fallback;
       }
 
       return result;
     }
 
-    return result?.textContent ?? '';
+    return result?.textContent || fallback;
   }
 }