From 4e1095d8ef081a4d128cf92813a4aa901752a59d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20S=C3=A1=20de=20Mello?= Date: Sun, 26 Jul 2026 10:13:16 +0100 Subject: [PATCH] Unblock CI: release 0.8.0 and stop codecov failing untrusted PRs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two checks (`semver` and `ubuntu / stable / coverage`) have been failing on every PR, including the Dependabot Action bumps (#118, #119), for reasons unrelated to those PRs: - semver: `main` is still versioned 0.7.1 (the last published release) but has accumulated breaking changes since that tag — the `Diagnose` trait was sealed (#107) and methods were removed from `InvalidCharacterError` (#108). `cargo-semver-checks` correctly demands a version bump. Bump to 0.8.0 (a minor bump, which permits breaking changes for a 0.x crate) and roll the CHANGELOG's Unreleased section into a 0.8.0 entry. - coverage: `CODECOV_TOKEN` is not available to Dependabot or fork PRs (secrets are withheld from untrusted contexts), so codecov can't create a commit on the protected branch and the upload errors out. Make `fail_ci_if_error` conditional so the error is only fatal for trusted PRs and pushes to main, where the token is present. Claude-Session: https://claude.ai/code/session_01XGvHsB4a2dxDVUQDGBScnW --- .github/workflows/test.yml | 7 ++++++- CHANGELOG.md | 2 ++ Cargo.lock | 2 +- Cargo.toml | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6826f77..ea570da 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -151,6 +151,11 @@ jobs: - name: Upload to codecov.io uses: codecov/codecov-action@v4 with: - fail_ci_if_error: true + # Dependabot and fork PRs don't have access to CODECOV_TOKEN + # (secrets are withheld from untrusted contexts), so codecov + # can't create a commit on the protected branch and the upload + # errors. Only treat that error as fatal for trusted PRs and + # pushes to main, where the token is available. + fail_ci_if_error: ${{ !(github.event.pull_request.head.repo.fork == true || github.actor == 'dependabot[bot]') }} token: ${{ secrets.CODECOV_TOKEN }} env_vars: OS,RUST diff --git a/CHANGELOG.md b/CHANGELOG.md index a998a26..4e2a63b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +## [0.8.0] 2026-07-26 + ### Deprecated - Deprecated `ResolveError` name. diff --git a/Cargo.lock b/Cargo.lock index 01eef82..011b5a3 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -135,7 +135,7 @@ checksum = "49f1f14873335454500d59611f1cf4a4b0f786f9ac11f4312a78e4cf2566695b" [[package]] name = "jsonptr" -version = "0.7.1" +version = "0.8.0" dependencies = [ "miette", "quickcheck", diff --git a/Cargo.toml b/Cargo.toml index 5a68954..7b0c20d 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -13,7 +13,7 @@ license = "MIT OR Apache-2.0" name = "jsonptr" repository = "https://github.com/chanced/jsonptr" rust-version = "1.79.0" -version = "0.7.1" +version = "0.8.0" [dependencies] miette = { version = "7.4.0", optional = true, features = ["fancy"] }