Skip to content

Commit 2d413f5

Browse files
authored
Merge pull request #24 from ciatph/testing-ci-node-version
Updated README. Added notes on PR's and Travis CI checks.
2 parents 0500e50 + 1058503 commit 2d413f5

1 file changed

Lines changed: 15 additions & 5 deletions

File tree

README.md

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,21 @@ Read on this [reference](https://trello.com/c/0A36NOdS) for more information on
5050

5151
2. Edit and push updates to `my-updates-branch`.
5252

53-
2. Create a pull request from the `my-updates-branch` that you've created to branch `vue-version`.
54-
55-
3. Approve the pull request.
56-
57-
4. View the travis CI status from [https://travis-ci.com/ciatph/ciatph.github.io](https://travis-ci.com/ciatph/ciatph.github.io). <br>
53+
3. Create a new **Pull Request (PR)** from the `my-updates-branch` that you've created to branch `vue-version`.
54+
- Go to `my-updates-branch` page in GitHub, i.e.:
55+
https://github.com/ciatph/ciatph.github.io/tree/my-updates-branch
56+
- Press the **[New pull request]** button beside the branch navigator dropdown menu [Branch: my-updates-branch].
57+
58+
4. Set the following in the resulting **"Open a pull request"** page:
59+
- **base:** `vue-version`
60+
- **compare:** `my-updates-branch`
61+
- Press the **[Create pull request]** button.
62+
- **WAIT** for the Travis CI checks to finish.
63+
64+
5. Press the **[Merge pull request]** button.
65+
> WARNING: It is important to **WAIT** for the Travis CI checks from #4 to finish first before pressing this button, else the Travis CI build will fail.
66+
67+
6. View the travis CI status from [https://travis-ci.com/ciatph/ciatph.github.io](https://travis-ci.com/ciatph/ciatph.github.io). <br>
5868
New GitHub pages website updates can be viewed from [https://ciatph.github.io](https://ciatph.github.io) if the build passed.
5969

6070

0 commit comments

Comments
 (0)