Render class list from POPOs, not Models

Before this change, when rendering the `cbv/_klass_list.html` template,
we passed in models and rendered the data from them.

To put a layer between the models and the display logic, this first puts
the required data onto a Plain Old Python Object, and then passes that
into the templates.

Author: meshy

cbv/templates/cbv/_klass_list.html

@@ -1,14 +1,14 @@
 <div class="span{{ column_width }}">
 {% for obj in object_list %}
-    {% ifchanged obj.module.name %}
+    {% ifchanged obj.module_name %}
         {% if not forloop.first %}</ul></div>{% endif %}
-        {% if obj.module.short_name == 'detail'%}</div><div class="span{{ column_width }}">{% endif %}
+        {% if obj.module_short_name == 'detail'%}</div><div class="span{{ column_width }}">{% endif %}
         <div class="well skinny klass-list">
         <ul class="nav nav-list">
-        <li class="nav-header"><h3>{{ obj.module.long_name }}</h3></li>
+        <li class="nav-header"><h3>{{ obj.module_long_name }}</h3></li>
     {% endifchanged %}
     <li class="{% if obj.is_secondary %}secondary{% else %}primary{% endif %}">
-        <a href="{{ obj.get_absolute_url }}" {% if obj.docstring %}class="klass-tooltip" data-original-title="{{ obj.docstring }}" data-placement="bottom"{% endif %}>
+        <a href="{{ obj.url }}" {% if obj.docstring %}class="klass-tooltip" data-original-title="{{ obj.docstring }}" data-placement="bottom"{% endif %}>
             {{ obj.name }}
         </a>
     </li>

cbv/views.py

@@ -142,6 +142,17 @@ def get_context_data(self, **kwargs):
         }
 
 
+@attrs.frozen
+class DjangoClassListItem:
+    docstring: str
+    is_secondary: bool
+    name: str
+    module_long_name: str
+    module_name: str
+    module_short_name: str
+    url: str
+
+
 class VersionDetailView(TemplateView):
     template_name = "cbv/version_detail.html"
 
@@ -157,11 +168,20 @@ def get_context_data(self, **kwargs):
         nav = nav_builder.get_nav_data(project_version)
         return {
             "nav": nav,
-            "object_list": list(
-                Klass.objects.filter(
+            "object_list": [
+                DjangoClassListItem(
+                    docstring=class_.docstring,
+                    is_secondary=class_.is_secondary(),
+                    name=class_.name,
+                    module_long_name=class_.module.long_name,
+                    module_name=class_.module.name,
+                    module_short_name=class_.module.short_name,
+                    url=class_.get_absolute_url(),
+                )
+                for class_ in Klass.objects.filter(
                     module__project_version=project_version
                 ).select_related("module__project_version")
-            ),
+            ],
             "project": f"Django {project_version.version_number}",
             "version_switcher": version_switcher,
         }
@@ -177,11 +197,20 @@ def get_context_data(self, **kwargs):
         nav = nav_builder.get_nav_data(project_version)
         return {
             "nav": nav,
-            "object_list": list(
-                Klass.objects.filter(
+            "object_list": [
+                DjangoClassListItem(
+                    docstring=class_.docstring,
+                    is_secondary=class_.is_secondary(),
+                    name=class_.name,
+                    module_long_name=class_.module.long_name,
+                    module_name=class_.module.name,
+                    module_short_name=class_.module.short_name,
+                    url=class_.get_absolute_url(),
+                )
+                for class_ in Klass.objects.filter(
                     module__project_version=project_version
                 ).select_related("module__project_version")
-            ),
+            ],
             "project": f"Django {project_version.version_number}",
             "version_switcher": version_switcher,
         }