Skip to content

CI: Allow additional ops file for docker start-bosh#2734

Merged
selzoc merged 1 commit into
mainfrom
docker-cpi-additional-ops
May 14, 2026
Merged

CI: Allow additional ops file for docker start-bosh#2734
selzoc merged 1 commit into
mainfrom
docker-cpi-additional-ops

Conversation

@selzoc
Copy link
Copy Markdown
Member

@selzoc selzoc commented May 14, 2026

Also, revert the gcp-internal-dns-ops file to only use gcp internal DNS.

Also, revert the gcp-internal-dns-ops file to _only_ use gcp internal
DNS.

ai-assisted=yes
[TNZ-88995]
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0c0505c8-2219-4148-9f74-12c4fec451b2

📥 Commits

Reviewing files that changed from the base of the PR and between 7f26d11 and 8072d61.

📒 Files selected for processing (2)
  • ci/dockerfiles/docker-cpi/gcp-internal-dns-ops.yml
  • ci/dockerfiles/docker-cpi/start-bosh.sh

Walkthrough

This pull request makes two independent updates to the BOSH CI infrastructure. The first change modifies the GCP DNS configuration to use only the internal DNS server (169.254.169.254), removing the external Google DNS entry (8.8.8.8). The second change extends the BOSH director deployment script to support injecting additional ops files through the ADDITIONAL_DIRECTOR_OPS_FILES environment variable, enabling more flexible deployment configurations without script modifications.

Suggested reviewers

  • aramprice
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docker-cpi-additional-ops

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@selzoc selzoc merged commit 5afc2fd into main May 14, 2026
21 of 22 checks passed
@selzoc selzoc deleted the docker-cpi-additional-ops branch May 14, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants