Show full scores in analysis mode and minor fixes

When the contest is in analysis mode (actual_phase == 3) total/task tokened scores are now shown as full scores instead of being limited to tokened submissions. Added joinedload(Participation.user) to the contest handler to eager-load users and avoid extra queries, and replaced per-task any(...) scans with a tokened_task_ids set for efficiency. The task submission handler now checks actual_phase to decide whether to restrict to tokened submissions. The template always renders a task score badge placeholder when sidebar scores are enabled so layout remains consistent. Also clarified related docstrings/comments.

Author: pxsit

cms/server/contest/handlers/contest.py

@@ -203,6 +203,7 @@ def _load_participation_for_scores(
             self.sql_session.query(Participation)
             .filter(Participation.id == participation.id)
             .options(
+                joinedload(Participation.user),
                 joinedload(Participation.contest)
                 .joinedload(Contest.tasks)
                 .joinedload(Task.active_dataset),
@@ -226,23 +227,28 @@ def _compute_task_scores(
         that task instead.
         """
         task_scores: dict[int, tuple[float, float, str]] = {}
+        tokened_task_ids = {
+            s.task_id for s in participation.submissions if s.official and s.tokened()
+        }
 
         for task in participation.contest.tasks:
             score_type = task.active_dataset.score_type_object
 
-            has_tokened_submission = any(
-                s.official and s.task_id == task.id and s.tokened()
-                for s in participation.submissions
-            )
+            has_tokened_submission = task.id in tokened_task_ids
             show_tokened_total = (
                 score_type.max_public_score < score_type.max_score
                 and (has_tokened_submission or actual_phase == 3)
             )
 
             if show_tokened_total:
-                score_value, _ = task_score(
-                    participation, task, only_tokened=True, rounded=True
-                )
+                if actual_phase == 3:
+                    # In analysis mode users can see full scores, so do not
+                    # restrict to tokened submissions.
+                    score_value, _ = task_score(participation, task, rounded=True)
+                else:
+                    score_value, _ = task_score(
+                        participation, task, only_tokened=True, rounded=True
+                    )
                 max_score_value = round(score_type.max_score, task.score_precision)
                 score_message = score_type.format_score(
                     score_value,

cms/server/contest/handlers/tasksubmission.py

@@ -207,8 +207,9 @@ def add_task_score(self, participation: Participation, task: Task, data: dict):
         task: task for which we want the score.
         data: where to put the data; all fields will start with "task",
             followed by "public" if referring to the public scores, or
-            "tokened" if referring to the total score (always limited to
-            tokened submissions); for both public and tokened, the fields are:
+            "tokened" if referring to the total score (limited to tokened
+            submissions during contest, full score in analysis mode); for both
+            public and tokened, the fields are:
             "score" and "score_message"; in addition we have
             "task_is_score_partial" as partial info is the same for both.
 
@@ -222,8 +223,14 @@ def add_task_score(self, participation: Participation, task: Task, data: dict):
             .all()
         data["task_public_score"], public_score_is_partial = \
             task_score(participation, task, public=True, rounded=True)
-        data["task_tokened_score"], tokened_score_is_partial = \
-            task_score(participation, task, only_tokened=True, rounded=True)
+        if self.r_params["actual_phase"] == 3:
+            data["task_tokened_score"], tokened_score_is_partial = task_score(
+                participation, task, rounded=True
+            )
+        else:
+            data["task_tokened_score"], tokened_score_is_partial = task_score(
+                participation, task, only_tokened=True, rounded=True
+            )
         # These two should be the same, anyway.
         data["task_score_is_partial"] = \
             public_score_is_partial or tokened_score_is_partial

cms/server/contest/templates/contest.html

@@ -181,10 +181,14 @@ <h3 id="countdown_box">
         {% for t_iter in contest.tasks %}
                             <li class="nav-header" data-task-name="{{ t_iter.name }}">
                                 <span>{{ t_iter.name }}</span>
-            {% if contest.show_task_scores_in_sidebar and sidebar_task_scores is defined and t_iter.id in sidebar_task_scores %}
+            {% if contest.show_task_scores_in_sidebar %}
+                {% if sidebar_task_scores is defined and t_iter.id in sidebar_task_scores %}
                                 <span class="task_score_badge task_score {{ get_score_class(sidebar_task_scores[t_iter.id][0], sidebar_task_scores[t_iter.id][1], t_iter.score_precision) }}">
                                     {{ sidebar_task_scores[t_iter.id][2] }}
                                 </span>
+                {% else %}
+                                <span class="task_score_badge task_score undefined"></span>
+                {% endif %}
             {% endif %}
                             </li>
                             <li{% if page == "task_description" and task == t_iter %} class="active"{% endif %}>