Merge pull request #847 from code0-tech/843-drop-dti-from-reference-value

Drop frontend fields from reference value

Author: Taucher2003

app/graphql/types/input/reference_value_input_type.rb

@@ -9,13 +9,6 @@ class ReferenceValueInputType < Types::BaseInputObject
                required: true, description: 'The paths associated with this reference value'
 
       argument :node_function_id, GlobalIdType[::NodeFunction], required: true, description: 'The referenced value'
-
-      argument :data_type_identifier, Types::Input::DataTypeIdentifierInputType,
-               required: true, description: 'The identifier of the data type this reference value belongs to'
-
-      argument :depth, Int, required: true, description: 'The depth of the reference value'
-      argument :node, Int, required: true, description: 'The node of the reference'
-      argument :scope, [Int], required: true, description: 'The scope of the reference value'
     end
   end
 end

app/graphql/types/reference_value_type.rb

@@ -6,13 +6,6 @@ class ReferenceValueType < Types::BaseObject
 
     field :node_function_id, GlobalIdType[::NodeFunction], null: false, description: 'The referenced value.'
 
-    field :data_type_identifier, Types::DataTypeIdentifierType,
-          null: false, description: 'The identifier of the data type this reference value belongs to.'
-
-    field :depth, Int, null: false, description: 'The depth of the reference value.'
-    field :node, Int, null: false, description: 'The node of the reference value.'
-    field :scope, [Int], null: false, description: 'The scope of the reference value.'
-
     field :reference_path, [Types::ReferencePathType],
           null: false,
           description: 'The paths associated with this reference value.',

app/models/reference_value.rb

@@ -2,7 +2,6 @@
 
 class ReferenceValue < ApplicationRecord
   belongs_to :node_function # real value association
-  belongs_to :data_type_identifier
   has_many :reference_paths, inverse_of: :reference_value, autosave: true, dependent: :destroy
   has_many :node_parameters, inverse_of: :reference_value
 

app/services/namespaces/projects/flows/update_service.rb

@@ -201,12 +201,6 @@ def update_node_parameters(t, current_node, current_node_input, all_nodes)
             end
 
             if parameter.value.reference_value.present?
-              data_type_identifier = get_data_type_identifier(
-                flow.project.primary_runtime,
-                parameter.value.reference_value.data_type_identifier,
-                t
-              )
-
               referenced_node = all_nodes.find do |n|
                 n[:input].id == parameter.value.reference_value.node_function_id
               end
@@ -229,11 +223,7 @@ def update_node_parameters(t, current_node, current_node_input, all_nodes)
               end
 
               reference_value.assign_attributes(
-                data_type_identifier: data_type_identifier,
                 node_function: referenced_node[:node],
-                depth: parameter.value.reference_value.depth,
-                node: parameter.value.reference_value.node,
-                scope: parameter.value.reference_value.scope,
                 reference_paths: reference_paths
               )
             else

db/migrate/20260209200852_drop_frontend_fields_from_reference_value.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class DropFrontendFieldsFromReferenceValue < Code0::ZeroTrack::Database::Migration[1.0]
+  def change
+    remove_reference :reference_values, :data_type_identifier, null: false, foreign_key: {
+      to_table: :data_type_identifiers, on_delete: :restrict
+    }
+
+    remove_column :reference_values, :scope, :integer, array: true, null: false, default: []
+    remove_column :reference_values, :node, :integer, null: false, default: 0
+    remove_column :reference_values, :depth, :integer, null: false, default: 0
+  end
+end

db/schema_migrations/20260209200852

@@ -0,0 +1 @@
+6ad01c08408e467d3ff1ac8470da7ab77a852632896297e05d1dc2cc77e190b9

db/structure.sql

@@ -668,11 +668,7 @@ CREATE TABLE reference_values (
     id bigint NOT NULL,
     created_at timestamp with time zone NOT NULL,
     updated_at timestamp with time zone NOT NULL,
-    node_function_id bigint NOT NULL,
-    depth integer DEFAULT 0 NOT NULL,
-    node integer DEFAULT 0 NOT NULL,
-    scope integer[] DEFAULT '{}'::integer[] NOT NULL,
-    data_type_identifier_id bigint NOT NULL
+    node_function_id bigint NOT NULL
 );
 
 CREATE SEQUENCE reference_values_id_seq
@@ -1213,8 +1209,6 @@ CREATE INDEX index_parameter_definitions_on_runtime_parameter_definition_id ON p
 
 CREATE INDEX index_reference_paths_on_reference_value_id ON reference_paths USING btree (reference_value_id);
 
-CREATE INDEX index_reference_values_on_data_type_identifier_id ON reference_values USING btree (data_type_identifier_id);
-
 CREATE INDEX index_reference_values_on_node_function_id ON reference_values USING btree (node_function_id);
 
 CREATE INDEX index_runtime_function_definitions_on_return_type_id ON runtime_function_definitions USING btree (return_type_id);
@@ -1375,9 +1369,6 @@ ALTER TABLE ONLY flow_type_settings
 ALTER TABLE ONLY flows
     ADD CONSTRAINT fk_rails_ab927e0ecb FOREIGN KEY (project_id) REFERENCES namespace_projects(id) ON DELETE CASCADE;
 
-ALTER TABLE ONLY reference_values
-    ADD CONSTRAINT fk_rails_bb34a5d62c FOREIGN KEY (data_type_identifier_id) REFERENCES data_type_identifiers(id) ON DELETE RESTRICT;
-
 ALTER TABLE ONLY flows
     ADD CONSTRAINT fk_rails_bb587eff6a FOREIGN KEY (input_type_id) REFERENCES data_types(id) ON DELETE RESTRICT;