Merge pull request #150 from code0-tech/#149-wrong-http-signature

made http status code to i64

Author: raphael-goetz

crates/core/src/context/argument.rs

@@ -4,7 +4,7 @@ use std::convert::Infallible;
 use tucana::shared::value::Kind;
 use tucana::shared::{ListValue, NumberValue, Struct, Value};
 
-use crate::value::number_to_f64;
+use crate::value::{number_to_f64, number_to_i64_lossy};
 #[derive(Clone, Debug)]
 pub enum Argument {
     // Eval => Evaluated Value
@@ -52,6 +52,17 @@ impl TryFromArgument for NumberValue {
     }
 }
 
+impl TryFromArgument for i64 {
+    fn try_from_argument(a: &Argument) -> Result<Self, Signal> {
+        match a {
+            Argument::Eval(Value {
+                kind: Some(Kind::NumberValue(n)),
+            }) => number_to_i64_lossy(n).ok_or_else(|| type_err("Expected number", a)),
+            _ => Err(type_err("Expected number", a)),
+        }
+    }
+}
+
 impl TryFromArgument for f64 {
     fn try_from_argument(a: &Argument) -> Result<Self, Signal> {
         match a {

crates/core/src/runtime/functions/http.rs

@@ -114,19 +114,9 @@ fn create_response(
     _ctx: &mut Context,
     _run: &mut dyn FnMut(i64, &mut Context) -> Signal,
 ) -> Signal {
-    args!(args => http_status_code: String, headers: Struct, payload: Value);
+    args!(args => http_status_code: i64, headers: Struct, payload: Value);
     let mut fields = std::collections::HashMap::new();
-
-    let code = match http_status_code.as_str().parse::<i64>() {
-        Ok(c) => c,
-        Err(_) => {
-            return Signal::Failure(RuntimeError::simple_str(
-                "InvalidArgumentExeption",
-                "Expected http_status_code to be parsed to integer",
-            ));
-        }
-    };
-    fields.insert("status_code".to_string(), value_from_i64(code));
+    fields.insert("status_code".to_string(), value_from_i64(http_status_code));
 
     fields.insert(
         "headers".to_string(),

flows/01_return_object.json

@@ -42,7 +42,9 @@
 						"runtimeParameterId": "http_status_code",
 						"value": {
 							"literalValue": {
-								"stringValue": "200"
+								"numberValue": {
+									"integer": "200"
+								}
 							}
 						}
 					},

flows/02_return_flow_input.json

@@ -54,7 +54,9 @@
 						"runtimeParameterId": "http_status_code",
 						"value": {
 							"literalValue": {
-								"stringValue": "200"
+								"numberValue": {
+									"integer": "200"
+								}
 							}
 						}
 					},