Skip to content

e2e: cover secure channel connect pairing and message bridging #222

Description

@codeaholicguy

Current coverage

No E2E covers Telegram or Slack connect, authorization, foreground bridge input, or response delivery.

What is missing

  • channel connect telegram token validation, named configuration, uniqueness, and authorization preservation
  • channel connect slack token validation, identity persistence, and secret redaction
  • Explicit authorized-user pairing and revocation for both providers
  • Rejection of a second user/chat
  • Foreground channel start agent resolution, terminal forwarding, and response delivery
  • channel list, disconnect, and authorization state output

Risk ranking

Critical, rank 2: the audit found that any workspace member can win Slack control by sending the first DM.

Recommended E2E tests

  • Drive a fake Slack Socket Mode boundary with two user IDs and assert only an explicitly paired user reaches the fake terminal.
  • Assert Telegram pairing persistence, rejection of another chat, and explicit re-pair behavior using a local fake Bot API boundary.

Acceptance criteria

  • The checklist tests are merged under e2e/.
  • No real channel credentials or external network calls are used.
  • Tests assert secrets never appear in stdout, stderr, logs, or fixtures.
  • Both accepted and rejected messages are proven at the terminal boundary.

Related audit findings

A2 and D2: Slack first-DM-wins and secure pairing. C4: authorization is conflated with conversation selection. A5 and D5: polling overlap and delivery reliability.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions