-
Notifications
You must be signed in to change notification settings - Fork 5
Expand file tree
/
Copy pathcode-review.mdc
More file actions
27 lines (16 loc) · 887 Bytes
/
code-review.mdc
File metadata and controls
27 lines (16 loc) · 887 Bytes
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
---
description: "PR checklist for @contentstack/delivery-sdk — API, types, core bump, tests"
alwaysApply: true
---
# Code review — `@contentstack/delivery-sdk`
## Public API
- **Exported** `stack`, **Stack**, query/entry/asset types match **README** and **`.d.ts`** output in **`dist/modern/`**.
- **JSDoc** on **`stack()`** and key public methods when behavior or options change.
## Compatibility
- Avoid breaking **StackConfig** or method chains without semver strategy; document migration for breaking changes.
## Core / deps
- **`@contentstack/core`** version changes: verify interceptors, errors, and **httpClient** options in **`contentstack.ts`**.
## Tests
- **Unit** coverage for new logic; **API** updates when CDA request/response behavior changes; **browser** if bundling or globals affected.
## Security
- No hardcoded tokens; no logging secrets in new code.