Merge pull request #549 from corbitsdev/cl-6934-surface-compaction-in-the-tui-when-it-actually-runs

Flash when compaction actually folds turns away

Author: TheGreatAxios

src/session/runtime-assembly.test.ts

@@ -285,4 +285,38 @@ describe("createSessionPruningCompactor", () => {
     await llm.apply(turns as never, { state: {} as never, trigger: "test" });
     expect(captured).toBe(ctx);
   });
+
+  test("onFolded fires only when turns were actually folded", async () => {
+    const folds: { turnsBefore: number; turnsAfter: number }[] = [];
+    const summarize = async () => "summary";
+    const folding = createSessionPruningCompactor({
+      compactionMode: "llm",
+      summarize,
+      onFolded: (info) => folds.push(info),
+    });
+    const now = Date.now();
+    const many = Array.from({ length: 8 }, (_, i) => ({
+      role: i % 2 === 0 ? "user" : "assistant",
+      content: [{ type: "text", text: `t${i}` }],
+      timestamp: now,
+    }));
+    await folding.apply(many as never, { state: {} as never, trigger: "test" });
+    expect(folds).toHaveLength(1);
+    expect(folds[0]?.turnsBefore).toBe(8);
+    expect(folds[0]?.turnsAfter).toBeLessThan(8);
+
+    const silent: { turnsBefore: number; turnsAfter: number }[] = [];
+    const noop = createSessionPruningCompactor({
+      compactionMode: "llm",
+      summarize,
+      onFolded: (info) => silent.push(info),
+    });
+    const few = Array.from({ length: 3 }, (_, i) => ({
+      role: i % 2 === 0 ? "user" : "assistant",
+      content: [{ type: "text", text: `t${i}` }],
+      timestamp: now,
+    }));
+    await noop.apply(few as never, { state: {} as never, trigger: "test" });
+    expect(silent).toEqual([]);
+  });
 });

src/session/runtime-assembly.ts

@@ -268,6 +268,8 @@ export interface SessionPruningCompactorArgs {
   summarize: (turns: ConversationTurn[], ctx?: SummaryContext) => Promise<string>;
   summaryContext?: () => SummaryContext | undefined;
   telemetry?: Telemetry;
+  /** Fires only when turns were actually folded away — not on no-ops. */
+  onFolded?: (info: { turnsBefore: number; turnsAfter: number }) => void;
 }
 
 /** Shared pruning-compactor defaults for the main session agent. */
@@ -296,6 +298,7 @@ export function createSessionPruningCompactor(args: SessionPruningCompactorArgs)
           turns_before: turnsBefore,
           turns_after: result.output.length,
         });
+        args.onFolded?.({ turnsBefore, turnsAfter: result.output.length });
       }
       return result;
     },

src/tui/product-host.ts

@@ -25,6 +25,8 @@ import {
   type ChromeLiveState,
 } from "./chrome-state.js";
 import {
+  compactionFoldInfo,
+  compactionNotice,
   grantApproval,
   grantNotice,
   hookNotice,
@@ -396,6 +398,7 @@ export async function mountProductHost(config: ProductHostConfig): Promise<Produ
     config.eventEmitter.off("hook", onHook);
     config.eventEmitter.off("mcp.status", onMcpStatus);
     config.eventEmitter.off("permission.grant", onPermissionGrant);
+    config.eventEmitter.off("compaction", onCompaction);
     bridge.dispose();
     // Cancels any flash still counting down: its expiry repaints, and after
     // teardown that repaint reaches a destroyed text buffer.
@@ -462,6 +465,12 @@ export async function mountProductHost(config: ProductHostConfig): Promise<Produ
     if (approval !== null) show(grantNotice(approval));
   }
 
+  function onCompaction(payload: unknown): void {
+    if (disposed) return;
+    const info = compactionFoldInfo(payload);
+    if (info !== null) show(compactionNotice(info));
+  }
+
   // The renderer already owns the alternate screen and raw mode by this point,
   // but `dispose` has not been handed to any caller yet — a throw here would
   // leave the terminal wedged with nobody able to restore it.
@@ -616,6 +625,7 @@ export async function mountProductHost(config: ProductHostConfig): Promise<Produ
   config.eventEmitter.on("hook", onHook);
   config.eventEmitter.on("mcp.status", onMcpStatus);
   config.eventEmitter.on("permission.grant", onPermissionGrant);
+  config.eventEmitter.on("compaction", onCompaction);
 
   return {
     shell,

src/tui/runner.ts

@@ -1510,6 +1510,8 @@ export async function runTUI(initialConfig: Config): Promise<number> {
             summarize: compactionSummarize,
             summaryContext,
             telemetry: liveTelemetry,
+            // Main-session folds only — exec runner and subagents stay silent.
+            onFolded: (info) => emitter.emit("compaction", info),
           }),
         },
       });

src/tui/runtime-channels.test.ts

@@ -193,6 +193,31 @@ describe("permission.grant channel", () => {
   });
 });
 
+describe("compaction channel", () => {
+  test("a successful fold flashes before → after and holds no transcript row", async () => {
+    const { host, emitter, frame, cleanup } = await mountHeadless();
+    try {
+      emitter.emit("compaction", { turnsBefore: 42, turnsAfter: 8 });
+      const painted = await frame();
+      expect(painted).toContain("context compacted · 42 → 8 turns");
+      expect(host.shell.streamLog).toEqual([]);
+    } finally {
+      cleanup();
+    }
+  });
+
+  test("a bad payload paints nothing", async () => {
+    const { host, emitter, frame, cleanup } = await mountHeadless();
+    try {
+      emitter.emit("compaction", { turnsBefore: 42 });
+      expect(await frame()).not.toContain("context compacted");
+      expect(host.shell.streamLog).toEqual([]);
+    } finally {
+      cleanup();
+    }
+  });
+});
+
 describe("agents chrome (live strip above the prompt)", () => {
   test("setChrome with running agents paints the agents zone", async () => {
     const { host, frame, cleanup } = await mountHeadless({
@@ -266,7 +291,7 @@ describe("every emitted runtime channel has a subscriber", () => {
   emitted.delete("subagent.progress");
 
   test("the runner still emits the channels this suite knows about", () => {
-    for (const channel of ["hook", "mcp.status", "permission.grant"]) {
+    for (const channel of ["hook", "mcp.status", "permission.grant", "compaction"]) {
       expect([...emitted]).toContain(channel);
     }
   });

src/tui/runtime-notices.test.ts

@@ -4,6 +4,8 @@
 import { describe, expect, test } from "bun:test";
 
 import {
+  compactionFoldInfo,
+  compactionNotice,
   grantApproval,
   grantNotice,
   hookNotice,
@@ -104,6 +106,15 @@ describe("grantNotice", () => {
   });
 });
 
+describe("compactionNotice", () => {
+  test("flashes before → after turn counts", () => {
+    expect(compactionNotice({ turnsBefore: 42, turnsAfter: 8 })).toEqual({
+      kind: "flash",
+      text: "context compacted · 42 → 8 turns",
+    });
+  });
+});
+
 describe("payload validation", () => {
   test("hook events that are not hook.updated are dropped", () => {
     expect(lifecycleHookEvent({ type: "hooks.loaded", hooks: [] })).toBeNull();
@@ -140,4 +151,14 @@ describe("payload validation", () => {
     });
     expect(subAgentProgress({ description: "map callers" })).toBeNull();
   });
+
+  test("compaction payloads require both turn counts and reject junk", () => {
+    expect(compactionFoldInfo({ turnsBefore: 42, turnsAfter: 8 })).toEqual({
+      turnsBefore: 42,
+      turnsAfter: 8,
+    });
+    expect(compactionFoldInfo({ turnsBefore: 42 })).toBeNull();
+    expect(compactionFoldInfo(null)).toBeNull();
+    expect(compactionFoldInfo("nope")).toBeNull();
+  });
 });

src/tui/runtime-notices.ts

@@ -1,6 +1,6 @@
 /**
- * Runtime side-channel notices: lifecycle hooks, MCP connection state and
- * recorded permission grants.
+ * Runtime side-channel notices: lifecycle hooks, MCP connection state,
+ * recorded permission grants, and successful context compaction.
  *
  * These channels are chatter by default and only sometimes news. The split
  * this module encodes:
@@ -9,7 +9,8 @@
  *   still be able to read after scrolling away (a hook that failed, an MCP
  *   server asking for authorization or refusing to connect);
  * - a **flash** is for confirmation of something they just caused, true only
- *   for a moment (a hook that ran, a server that came up, a grant recorded);
+ *   for a moment (a hook that ran, a server that came up, a grant recorded,
+ *   a compaction that folded turns away);
  * - **null** is for inventory and intermediate states (`hooks.loaded`, a
  *   server that is merely `connecting`) — the /hooks and /mcp panels own that.
  *
@@ -108,6 +109,19 @@ export function grantNotice(approval: Approval): RuntimeNotice {
   };
 }
 
+export interface CompactionFoldInfo {
+  readonly turnsBefore: number;
+  readonly turnsAfter: number;
+}
+
+/** Confirmation that context compaction actually folded turns away. */
+export function compactionNotice(info: CompactionFoldInfo): RuntimeNotice {
+  return {
+    kind: "flash",
+    text: `context compacted · ${info.turnsBefore} → ${info.turnsAfter} turns`,
+  };
+}
+
 // ---------------------------------------------------------------------------
 // Emitter payload validation
 // ---------------------------------------------------------------------------
@@ -168,6 +182,17 @@ export function grantApproval(raw: unknown): Approval | null {
   return parsed.approval as Approval;
 }
 
+const compactionPayload = type({
+  turnsBefore: "number",
+  turnsAfter: "number",
+});
+
+export function compactionFoldInfo(raw: unknown): CompactionFoldInfo | null {
+  const parsed = compactionPayload(raw);
+  if (parsed instanceof type.errors) return null;
+  return parsed;
+}
+
 export interface SubAgentProgress {
   readonly description: string;
   readonly toolName: string;