Fix lint on Codex apply-patch proxy types

Author: TheGreatAxios

docs/IMPLEMENTATION.md

@@ -161,6 +161,7 @@ Sixteen packages under `src/agent/directors/<id>/` register in `DIRECTOR_REGISTR
 5. Primary chat role is Skywalker: `buildChatRole()` → `createSkywalkerSystemPrompt()`. Product mutation tools (`write_file` / `edit_file` / `delete_file`) live in CORE (and `SKYWALKER_TOOLS`) so they are advertised on the primary without a `tool_search` round-trip. DIY tiny/bounded edits on the parent; spawn build/docs directors for substantial work — a prompt judgment call, not a toolset strip. `PRIMARY_DENIED_PRODUCT_TOOLS` is gone. Shell file-writes stay denied; MCP tools are not re-filtered by a product-write deny list. Optional `writePaths` (when a profile sets it) only gate path-keyed product tools.
 
    **Codex tool proxies.** When the active provider is Codex (`isCodexProviderName`), `createAgentToolset` and `runSubAgent` mount `apply_patch`, `shell`, and `update_plan` stringTools from `createCodexToolProxies`, all forwarding through the same posix `ToolRunner` seam (`runTool`) so permission plugins still apply. `apply_patch` parses the Codex envelope and forwards each op (`write_file` / `delete_file` / `read_file`). `shell` — the native Codex name is `shell`, not `exec_command`, per the pinned base-instructions text quoted in `codex-responses-adapter.ts`'s bridge message — normalizes Codex's `command` (string or `["bash","-lc",script]`-style argv array), `workdir`, and `timeout_ms` onto `run_shell`'s `{command, cwd?, timeout?}` and is gated by `allowShellFromCapabilities` (mirrors `allowDeleteFromCapabilities` against `run_shell`). `update_plan` maps Codex's `plan: [{step, status}]` onto `manage_tasks(action: "create")`; `pending`/`in_progress`/`completed` map to `todo`/`doing`/`done` — `manage_tasks`'s `cancelled` status has no Codex equivalent and is never produced by this proxy. Primary strips `apply_patch` after mount (Corbits DIY stays on `write_file` / `edit_file` / `delete_file`); `shell` and `update_plan` stay on primary (same classification as `run_shell` / `manage_tasks`). Build and docs leaf allowlists (`BUILD_TOOLS` / `DOCS_TOOLS`) include `apply_patch` so Codex workers keep the proxy after the capability filter. `CORE_TOOL_NAMES` does not list it.
+
 6. Shipped directors omit `writePaths`. The optional field is still enforced in the permission gate via ALS identity (`identity-context.ts` + `write-path-policy.ts`) when a plugin/custom profile sets it.
 7. Spawn effort: pin > package `modelRole` default (`defaultEffortForDirector`; intern=low; plan/review/orchestrator=high; implement/explore/docs/test=medium) > orchestrator/worker binary > parent inheritance. Optional skills are listed in the identity header for awareness; workers do not mount `use_skill` (guidance is baked into package system prompts). Primary mounts `use_skill` for its own skill list.
 

src/agent/codex-apply-patch.ts

@@ -27,19 +27,19 @@ const END_OF_FILE = "*** End of File";
 
 export type HunkLineKind = " " | "-" | "+";
 
-export type PatchHunkLine = {
+export interface PatchHunkLine {
   kind: HunkLineKind;
   text: string;
-};
+}
 
-export type PatchHunk = {
+export interface PatchHunk {
   /** Optional text after `@@` (class/method anchor). */
   header?: string;
   lines: PatchHunkLine[];
   endOfFile?: boolean;
-};
+}
 
-export type PatchAddOp = {
+export interface PatchAddOp {
   type: "add";
   path: string;
   /**
@@ -48,25 +48,25 @@ export type PatchAddOp = {
    * An Add File with no `+` lines yields `""`.
    */
   content: string;
-};
+}
 
-export type PatchDeleteOp = {
+export interface PatchDeleteOp {
   type: "delete";
   path: string;
-};
+}
 
-export type PatchUpdateOp = {
+export interface PatchUpdateOp {
   type: "update";
   path: string;
   moveTo?: string;
   hunks: PatchHunk[];
-};
+}
 
 export type PatchOp = PatchAddOp | PatchDeleteOp | PatchUpdateOp;
 
-export type ParsedPatch = {
+export interface ParsedPatch {
   ops: PatchOp[];
-};
+}
 
 export class CodexApplyPatchError extends Error {
   constructor(message: string) {

src/agent/codex-tool-proxies.test.ts

@@ -12,7 +12,10 @@ import {
 import { DOCS_TOOLS, BUILD_TOOLS } from "./directors/tool-sets.js";
 import { applyManageTasks, parseManageTasksArgs, type Task } from "./tasks.js";
 
-type Call = { name: string; args: Record<string, unknown> };
+interface Call {
+  name: string;
+  args: Record<string, unknown>;
+}
 
 // `manage_tasks` is deliberately NOT a branch here: the real posixTools
 // registry runTool forwards to has no manage_tasks handler (only

src/agent/codex-tool-proxies.ts

@@ -33,7 +33,7 @@ export type CodexRunManageTasks = (
   args: Record<string, unknown>,
 ) => Promise<{ content: string; isError?: boolean }>;
 
-export type CreateCodexToolProxiesOpts = {
+export interface CreateCodexToolProxiesOpts {
   isCodex: boolean;
   runTool: CodexRunTool;
   /** Dispatches update_plan's translated manage_tasks(action="create") call. */
@@ -49,7 +49,7 @@ export type CreateCodexToolProxiesOpts = {
    * Docs leaves pass false because DOCS_TOOLS omits run_shell.
    */
   allowShell?: boolean;
-};
+}
 
 const ApplyPatchArgs = type({
   input: "string>0",