Tighten the ProviderCatalogEntry round-trip test and its comment

The round-trip test omitted keyless, anthropic, and opencodeGo, so it
could not actually catch a dropped optional field despite claiming to
exercise every field. Split anthropic/opencodeGo into their own cases
since both also normalize baseURL in buildProviderCatalog, and cover
keyless in the base case. Also correct the ProviderCatalogEntry doc
comment: the Omit/intersection only forces literals to supply a newly
required field: an optional field can still be silently dropped by a
hand-written conversion, which is why the round-trip test exists.

Author: TheGreatAxios

src/config.test.ts

@@ -6,6 +6,7 @@ import { join } from "node:path";
 import { buildBifrostSource, buildOpenAISource, buildProviderCatalog, catalogEntryAsProviderSettings, KEYLESS_API_KEY, loadConfig, providerCatalogToSettings, runtimeSettingsWithCatalog, SOURCE_MAX_TOKENS } from "./config/index.js";
 import type { Config, UnconfiguredConfig } from "./config/index.js";
 import { mergeProviderIntoSettings, type ResolvedProvider, type Settings } from "./config/settings.js";
+import { OPENCODE_GO_BASE_URL } from "../packages/opencode-go/src/index.js";
 
 function assertConfigured(config: Config | UnconfiguredConfig): asserts config is Config {
   if (config.configured === false) {
@@ -654,12 +655,17 @@ describe("buildProviderCatalog", () => {
     // This exercises every field that relationship carries over, so a field
     // added to ProviderSettings and forgotten in the two conversion sites
     // below fails here instead of being silently dropped at runtime.
+    // `anthropic` and `opencodeGo` are exercised separately below: both are
+    // protocol markers that also normalize `baseURL` in buildProviderCatalog,
+    // so a provider combining them with an arbitrary baseURL isn't a real
+    // round trip (the healing logic rewrites baseURL by design).
     const provider: Settings["providers"][string] = {
       baseURL: "https://fp/v1",
       apiKey: "fp-key",
       models: ["fp-large"],
       defaultModel: "fp-large",
       free: true,
+      keyless: true,
       bifrostVirtualKey: true,
     };
     const settings: Settings = { providers: { fp: provider } };
@@ -673,6 +679,44 @@ describe("buildProviderCatalog", () => {
     const roundTripped = { fp: catalogEntryAsProviderSettings(entry) };
     expect(roundTripped).toEqual({ fp: provider });
   });
+
+  test("round-trips the anthropic protocol marker", () => {
+    const provider: Settings["providers"][string] = {
+      baseURL: "https://api.anthropic.com/v1",
+      apiKey: "an-key",
+      models: ["claude"],
+      anthropic: true,
+    };
+    const settings: Settings = { providers: { an: provider } };
+    const catalog = buildProviderCatalog(settings, {
+      providerName: "an",
+      baseURL: provider.baseURL,
+      apiKey: "an-key",
+      model: "claude",
+    } as ResolvedProvider);
+    const entry = catalog.find((c) => c.name === "an")!;
+    const roundTripped = { an: catalogEntryAsProviderSettings(entry) };
+    expect(roundTripped).toEqual({ an: provider });
+  });
+
+  test("round-trips the opencodeGo protocol marker", () => {
+    const provider: Settings["providers"][string] = {
+      baseURL: OPENCODE_GO_BASE_URL,
+      apiKey: "go-key",
+      models: ["go-model"],
+      opencodeGo: true,
+    };
+    const settings: Settings = { providers: { go: provider } };
+    const catalog = buildProviderCatalog(settings, {
+      providerName: "go",
+      baseURL: provider.baseURL,
+      apiKey: "go-key",
+      model: "go-model",
+    } as ResolvedProvider);
+    const entry = catalog.find((c) => c.name === "go")!;
+    const roundTripped = { go: catalogEntryAsProviderSettings(entry) };
+    expect(roundTripped).toEqual({ go: provider });
+  });
 });
 
 describe("mergeProviderIntoSettings", () => {

src/config/index.ts

@@ -92,13 +92,17 @@ export function buildOpenAISource(fields: {
 // One configured provider the /agent modal can switch to. Carries credentials
 // because live switching builds an InferenceSource from it; the modal only ever
 // receives fields needed for provider management, never the key. Derived from
-// ProviderSettings (the persisted record) so a field added there is never
-// silently missing here: `name` becomes required (every catalog entry is
-// resolved to a concrete provider id) and `contextWindow` is dropped (it is a
-// settings-only override, never surfaced to the /agent modal). The
-// OAuth-profile markers below have no ProviderSettings counterpart because
-// such entries are never written to settings.json (their credentials live in
-// the Codex/xAI auth stores).
+// ProviderSettings (the persisted record) so the field *set* stays tied to it:
+// a newly required ProviderSettings field forces every catalog-entry literal
+// to supply it. `name` becomes required (every catalog entry is resolved to a
+// concrete provider id) and `contextWindow` is dropped (it is a settings-only
+// override, never surfaced to the /agent modal). The OAuth-profile markers
+// below have no ProviderSettings counterpart because such entries are never
+// written to settings.json (their credentials live in the Codex/xAI auth
+// stores). Optional fields still need the round-trip test in config.test.ts —
+// TS does not flag a missing optional property against an explicitly-typed
+// object literal, so forwarding of an optional field can only be caught at
+// runtime.
 export type ProviderCatalogEntry = Omit<ProviderSettings, "name" | "contextWindow"> & {
   name: string;
   // Set when this entry is a Codex OAuth profile rather than an API-key