Overhaul Bruckheimer prompt

Teach Bruckheimer named-identity product discovery docs with blinders on,
success-criteria capture, and no tool-schema restatement or fake caps.
Keep package id/path as bruckheimer.

Closes CL-7027

Author: TheGreatAxios

src/agent/directors/bruckheimer/package.test.ts

@@ -2,7 +2,7 @@ import { describe, expect, test } from "bun:test";
 import { bruckheimerPackage } from "./package.js";
 
 describe("bruckheimerPackage", () => {
-  test("id matches directory", () => {
+  test("id matches directory (keep bruckheimer path; identity is Bruckheimer)", () => {
     expect(bruckheimerPackage.id).toBe("bruckheimer");
   });
 
@@ -13,9 +13,59 @@ describe("bruckheimerPackage", () => {
 
   test("systemPrompt states PRIMARY INTENT", () => {
     expect(bruckheimerPackage.systemPrompt).toMatch(/PRIMARY INTENT/i);
-    expect(bruckheimerPackage.systemPrompt).toContain(
-      "Route those via Blockers to build, greybeard, critique, or skywalker",
-    );
+  });
+
+  test("systemPrompt identity is Bruckheimer / BruckheimerDirector", () => {
+    const p = bruckheimerPackage.systemPrompt;
+    expect(p).toMatch(/BruckheimerDirector \(Bruckheimer\)/);
+    expect(p).toMatch(/product-discovery lane only/i);
+    expect(p).not.toMatch(/ProductDiscoveryDirector/);
+  });
+
+  test("systemPrompt teaches product discovery docs (shape, not code)", () => {
+    const p = bruckheimerPackage.systemPrompt;
+    expect(p).toMatch(/product discovery documentation/i);
+    expect(p).toMatch(/product shape/i);
+    expect(p).toMatch(/first ninety seconds/i);
+    expect(p).toMatch(/discoverable affordances/i);
+    expect(p).toMatch(/failure states/i);
+    expect(p).toMatch(/Do not implement product code/i);
+    expect(p).toMatch(/PRODUCT \/ ARCHITECTURE \/ IMPLEMENTATION/i);
+  });
+
+  test("systemPrompt is blinders-on discovery lane (no ship / plan / arch / fleet)", () => {
+    const p = bruckheimerPackage.systemPrompt;
+    expect(p).toMatch(/Blinders on/i);
+    expect(p).toMatch(/Do not spawn specialists/i);
+    expect(p).toMatch(/not Builder/i);
+    expect(p).toMatch(/not Shakespeare/i);
+    expect(p).toMatch(/not Counsel/i);
+    expect(p).toMatch(/not Greybeard/i);
+    expect(p).toMatch(/not Critic/i);
+    expect(p).toMatch(/not an orchestrator/i);
+    expect(p).toMatch(/report Blockers/i);
+  });
+
+  test("systemPrompt has no tool-schema restatement or fake caps", () => {
+    const p = bruckheimerPackage.systemPrompt;
+    expect(p).not.toMatch(/parameters?:/i);
+    expect(p).not.toMatch(/fan-out/i);
+    expect(p).not.toMatch(/at most \d+/i);
+    expect(p).not.toMatch(/turn budget/i);
+    expect(p).not.toMatch(/scheduler/i);
+    expect(p).not.toMatch(/Write tools are mounted/i);
+    expect(p).not.toMatch(/path lock/i);
+    expect(p).not.toMatch(/Prefer grep\/search_files/i);
+    expect(p).not.toMatch(/Shell find\/rg/i);
+    expect(p).not.toMatch(/via run_shell/i);
+  });
+
+  test("systemPrompt has DONE GATE for success_criteria", () => {
+    const p = bruckheimerPackage.systemPrompt;
+    expect(p).toContain("DONE GATE");
+    expect(p).toContain("success_criteria");
+    expect(p).toMatch(/[Ss]top when/);
+    expect(p).toContain("Blockers");
   });
 
   test("spawn.maySpawn is false", () => {
@@ -36,5 +86,9 @@ describe("bruckheimerPackage", () => {
     expect(bruckheimerPackage.primaryIntent).toMatch(/product discovery/i);
     expect(bruckheimerPackage.outOfLane).toContain("shipping product code");
     expect(bruckheimerPackage.outOfLane).toContain("architecture gates");
+    expect(bruckheimerPackage.outOfLane).toContain(
+      "ongoing P/A/I docs maintenance as Shakespeare",
+    );
+    expect(bruckheimerPackage.outOfLane).toContain("ordered eng plans as Counsel");
   });
 });

src/agent/directors/bruckheimer/package.ts

@@ -2,7 +2,9 @@ import type { DirectorPackage } from "../types.js";
 import { DOCS_TOOLS } from "../tool-sets.js";
 
 /**
- * Product discovery specialist (CL-5824).
+ * Bruckheimer leaf (CL-5824 / CL-7027).
+ * Product discovery docs — invent/capture product shape; do not implement.
+ * Package id/path stays `bruckheimer` (global rename is out of scope).
  */
 export const bruckheimerPackage: DirectorPackage = {
   id: "bruckheimer",
@@ -13,21 +15,30 @@ export const bruckheimerPackage: DirectorPackage = {
     "feature implementation",
     "hard merge blockers as Greybeard",
     "running the fleet",
+    "ongoing P/A/I docs maintenance as Shakespeare",
+    "ordered eng plans as Counsel",
   ],
   description: "Product discovery specialist — user/product shape docs, not code",
   tools: { allow: DOCS_TOOLS },
   spawn: { maySpawn: false },
   tier: "leaf",
   modelRole: "docs",
-  systemPrompt: `You are BruckheimerDirector, a specialist in Corbits Code.
+  systemPrompt: `You are BruckheimerDirector (Bruckheimer), a specialist in Corbits Code.
 
-PRIMARY INTENT: product discovery documentation. Invent and capture product shape — who the user is, first ninety seconds, discoverable affordances, failure states, copy that should change.
+PRIMARY INTENT: product discovery documentation. Invent and capture product shape — who the user is, first ninety seconds, discoverable affordances, failure states, and copy that should change. Produce discovery that orients PRODUCT / ARCHITECTURE / IMPLEMENTATION briefs. Do not implement product code.
 
-Write tools are mounted with no path lock. Stay on the product-discovery lane. You are not an implementer. You are not the architecture gate (that is Greybeard). You do not ship features or product code.
+You are the product-discovery lane only — not Builder, not Shakespeare (ongoing P/A/I docs maintenance), not Counsel (ordered eng plans), not Greybeard (architecture gate), not Critic, not an orchestrator. Blinders on: stay on the brief's discovery ask. Do not spawn specialists. Do not ship features or become the architecture/docs/plan gate as your primary job.
 
-Read the product as a person using it: can a new user get through the first ninety seconds? Which affordances are discoverable and which exist only in a file nobody reads? What state is the user left in when something fails — do they know what to press? Name specific strings and surfaces that should change.
+Discover against the brief:
+1. Map every success_criteria item to product-shape facts you will capture (or Blockers if you cannot).
+2. Read the product as a person using it: can a new user get through the first ninety seconds? Which affordances are discoverable vs buried? What state is the user left in when something fails — do they know what to press?
+3. Name specific strings, surfaces, flows, and failure modes that should change — evidence over vibes.
+4. Capture discovery in product-shape docs/briefs that a parent can hand to Shakespeare, Counsel, or Builder. Prefer concrete user moments over abstract vision essays.
+5. Report product shape and discovery, paths touched, and Blockers.
 
-OUT OF LANE: implementing features, architecture sign-off, code review severity theater, fleet orchestration. Route those via Blockers to build, greybeard, critique, or skywalker.
+DONE GATE: Stop when every success_criteria item from the brief is answered OR explicitly blocked under Blockers. Do not invent architecture, ship code, author eng step-plans, or expand the brief after discovery is complete. If the ask needs implementation, eng planning, architecture sign-off, or ongoing docs maintenance, report Blockers naming Builder / Counsel / Greybeard / Shakespeare — do not become them.
 
-Findings: product shape and discovery, not implementation notes.`,
+OUT OF LANE: shipping product code, feature implementation, architecture gate sign-off, ordered eng plans, ongoing P/A/I docs maintenance, review severity theater, fleet orchestration, becoming Builder/Shakespeare/Counsel/Greybeard/Critic as primary.
+
+Findings: product shape and discovery — users, first ninety seconds, affordances, failure states, copy/surfaces to change — not implementation notes.`,
 };