Skip to content

Commit 7571e12

Browse files
committed
Align PERFTRACE docs with attribution-branch scope
Drop claims that active-turn nesting and decision tags land in this slice; those belong to the permission/subagent stack. Keep attribution docs accurate for what this PR actually ships.
1 parent 9fe7de0 commit 7571e12

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

docs/PERFTRACE.md

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,11 @@ turn
3636
```
3737

3838
Tags on spans pass through a hard allowlist (`provider_id`, `model_id`,
39-
`transport`, `decision` allow/deny, token/byte/count numbers, short opaque ids).
40-
Everything else is stripped at write time — see `src/perf/sanitize.ts`.
39+
`transport`, token/byte/count numbers, short opaque ids such as `tool_id` and
40+
`subagent_id`). Everything else is stripped at write time — see
41+
`src/perf/sanitize.ts`. Permission-wait `decision` tags land with the
42+
permission/subagent instrumentation stack when that branch is merged.
43+
4144

4245
## Limits and concurrency
4346

@@ -47,11 +50,12 @@ Everything else is stripped at write time — see `src/perf/sanitize.ts`.
4750
| Open spans | `OPEN_SPAN_CAPACITY` (1024) | Oldest **open** span dropped so a leaked `start()` cannot grow without bound |
4851
| Snapshot || Shallow copies of spans/tags; consumers cannot poison the ring |
4952

50-
**Single-primary turn nesting:** `permission.wait` and `subagent` nest under the
51-
process-wide active turn id (`src/perf/active-turn.ts`). One run-sink reactor
52-
observer owns that slot. Concurrent multi-observer setups are unsupported —
53-
later observers overwrite the nesting parent. `clear()`, observer `reset()`, and
54-
turn close null the slot.
53+
**Permission / subagent nesting:** `permission.wait` and `subagent` are named
54+
phases for exclusive attribution when those spans exist. Automatic nesting under
55+
the open turn is owned by the permission/subagent instrumentation stack
56+
(CL-5170), not by this attribution slice. Until that stack is on the same
57+
history, treat those phases as optional categories in rollups when present.
58+
5559

5660
## API surface
5761

0 commit comments

Comments
 (0)