Skip to content

Commit b103ff9

Browse files
committed
Remove Bifrost virtual key from the provider settings form
Drop the Bifrost toggle from agent-modal so operators no longer configure x-bf-vk through the UI. Existing runtime handling for stored configs is left intact. Closes CL-5344
1 parent 0f30d67 commit b103ff9

2 files changed

Lines changed: 4 additions & 18 deletions

File tree

src/tui/components/agent-modal.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,8 @@ const form = (overrides: Partial<ProviderFormValues> = {}): ProviderFormValues =
2626
keyless: "no",
2727
models: "fp-large, fp-small",
2828
defaultModel: "fp-large",
29-
bifrostVirtualKey: "no",
3029
...overrides,
31-
} as ProviderFormValues);
30+
});
3231

3332
describe("validateProviderForm", () => {
3433
test("creates a provider submission from comma-separated models", () => {

src/tui/components/agent-modal.tsx

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export type AgentProvider = {
4848

4949
export type { ProviderSubmission, ProviderSubmission as ProviderFormSubmission };
5050

51-
export type ProviderFormField = "name" | "baseURL" | "keyless" | "apiKey" | "models" | "defaultModel" | "bifrostVirtualKey";
51+
export type ProviderFormField = "name" | "baseURL" | "keyless" | "apiKey" | "models" | "defaultModel";
5252
export type ProviderFormValues = Record<ProviderFormField, string>;
5353
type Step =
5454
| "provider"
@@ -62,7 +62,7 @@ type Step =
6262
| "profile-form"
6363
| "profile-delete";
6464

65-
const FORM_FIELDS: readonly ProviderFormField[] = ["name", "baseURL", "keyless", "apiKey", "models", "defaultModel", "bifrostVirtualKey"];
65+
const FORM_FIELDS: readonly ProviderFormField[] = ["name", "baseURL", "keyless", "apiKey", "models", "defaultModel"];
6666

6767
const FIELD_LABELS: Record<ProviderFormField, string> = {
6868
name: "Provider name",
@@ -71,7 +71,6 @@ const FIELD_LABELS: Record<ProviderFormField, string> = {
7171
apiKey: "API key",
7272
models: "Models",
7373
defaultModel: "Default model",
74-
bifrostVirtualKey: "Bifrost virtual key",
7574
};
7675

7776
const FIELD_HINTS: Record<ProviderFormField, string> = {
@@ -81,7 +80,6 @@ const FIELD_HINTS: Record<ProviderFormField, string> = {
8180
apiKey: "sk-...",
8281
models: "model-a, model-b",
8382
defaultModel: "optional; must be in models",
84-
bifrostVirtualKey: "yes = use x-bf-vk header (Bifrost)",
8583
};
8684

8785
// Project provider catalog entries carry credentials. The modal receives the
@@ -153,7 +151,6 @@ function initialFormValues(provider: AgentProvider | undefined): ProviderFormVal
153151
apiKey: "",
154152
models: provider?.models.join(", ") ?? "",
155153
defaultModel: provider?.defaultModel ?? provider?.models[0] ?? "",
156-
bifrostVirtualKey: provider?.bifrostVirtualKey === true ? "yes" : "no",
157154
};
158155
}
159156

@@ -172,7 +169,6 @@ export function validateProviderForm(
172169
const baseURL = values.baseURL.trim();
173170
const apiKey = values.apiKey.trim();
174171
const keyless = values.keyless === "yes";
175-
const bifrostVirtualKey = values.bifrostVirtualKey === "yes";
176172
const models = parseModels(values.models);
177173
const defaultModel = values.defaultModel.trim();
178174

@@ -196,7 +192,6 @@ export function validateProviderForm(
196192
...(apiKey.length > 0 ? { apiKey } : {}),
197193
models,
198194
...(defaultModel.length > 0 ? { defaultModel } : {}),
199-
...(bifrostVirtualKey ? { bifrostVirtualKey: true } : {}),
200195
},
201196
};
202197
}
@@ -768,13 +763,6 @@ export function AgentModal({
768763
}
769764
return;
770765
}
771-
if (currentField === "bifrostVirtualKey") {
772-
if (key.leftArrow || key.rightArrow || input === " ") {
773-
setFormValues((v) => ({ ...v, bifrostVirtualKey: v.bifrostVirtualKey === "yes" ? "no" : "yes" }));
774-
setFormError(null);
775-
}
776-
return;
777-
}
778766
if (key.backspace || key.delete) {
779767
setFormValues((values) => ({ ...values, [currentField]: values[currentField].slice(0, -1) }));
780768
setFormError(null);
@@ -966,7 +954,6 @@ export function AgentModal({
966954
const showCaret =
967955
isCursor &&
968956
field !== "keyless" &&
969-
field !== "bifrostVirtualKey" &&
970957
!(field === "apiKey" && isKeyless);
971958
return (
972959
<Box key={field} flexDirection="row" gap={1}>
@@ -975,7 +962,7 @@ export function AgentModal({
975962
{FIELD_LABELS[field]}
976963
</Text>
977964
</Box>
978-
{field === "keyless" || field === "bifrostVirtualKey" ? (
965+
{field === "keyless" ? (
979966
<Text color={value === "yes" ? color("accent") : color("muted")}>
980967
{isCursor ? "< " : " "}
981968
{value === "yes" ? "yes" : "no"}

0 commit comments

Comments
 (0)