Mount write tools on every closed director (#634)

* Mount write tools on every closed director

Compose PRODUCT_WRITE_TOOLS onto review, orchestrator, intern, and docs
surfaces so lane discipline stays in prompts instead of tool stripping.

Closes CL-7014

* Fix prettier formatting in director tool-sets

Author: TheGreatAxios

src/agent/codex-tool-proxies.test.ts

@@ -597,8 +597,8 @@ describe("update_plan proxy", () => {
 });
 
 describe("allowDeleteFromCapabilities", () => {
-  test("docs allowlist (no delete_file) → false; build → true", () => {
-    expect(allowDeleteFromCapabilities({ mode: "allow", tools: DOCS_TOOLS })).toBe(false);
+  test("docs allowlist (includes delete_file) → true; build → true", () => {
+    expect(allowDeleteFromCapabilities({ mode: "allow", tools: DOCS_TOOLS })).toBe(true);
     expect(allowDeleteFromCapabilities({ mode: "allow", tools: BUILD_TOOLS })).toBe(true);
     expect(allowDeleteFromCapabilities(undefined)).toBe(true);
     expect(allowDeleteFromCapabilities({ mode: "exclude", tools: ["run_shell"] })).toBe(true);

src/agent/codex-tool-proxies.ts

@@ -55,8 +55,8 @@ export interface CreateCodexToolProxiesOpts {
   runManageTasks: CodexRunManageTasks;
   /**
    * When false, Delete File and Update+Move refuse without calling `delete_file`.
-   * Defaults to true (implement / unconstrained). Docs leaves pass false because
-   * DOCS_TOOLS includes apply_patch but not delete_file.
+   * Defaults to true (implement / unconstrained). Pass false when the
+   * director allowlist omits delete_file (docs leaves mount it today).
    */
   allowDelete?: boolean;
   /**

src/agent/directors/brand-reviewer/package.test.ts

@@ -73,6 +73,7 @@ describe("brandReviewerPackage", () => {
     const allow = brandReviewerPackage.tools?.allow ?? [];
     expect(allow).toContain("write_file");
     expect(allow).toContain("edit_file");
+    expect(allow).toContain("delete_file");
   });
 
   test("systemPrompt mentions DESIGN.md", () => {

src/agent/directors/bruckheimer/package.test.ts

@@ -26,6 +26,7 @@ describe("bruckheimerPackage", () => {
     const allow = bruckheimerPackage.tools?.allow ?? [];
     expect(allow).toContain("write_file");
     expect(allow).toContain("edit_file");
+    expect(allow).toContain("delete_file");
   });
 
   test("modelRole is docs", () => {

src/agent/directors/critique/package.test.ts

@@ -84,14 +84,14 @@ describe("critiquePackage", () => {
     expect(critiquePackage.spawn.maySpawn).toBe(false);
   });
 
-  test("tools.allow is review surface without product writes", () => {
+  test("tools.allow is review surface with product writes", () => {
     const allow = critiquePackage.tools?.allow ?? [];
     expect(allow).toContain("read_file");
     expect(allow).toContain("read_file");
     expect(allow).not.toContain("use_skill");
-    expect(allow).not.toContain("write_file");
-    expect(allow).not.toContain("edit_file");
-    expect(allow).not.toContain("delete_file");
+    expect(allow).toContain("write_file");
+    expect(allow).toContain("edit_file");
+    expect(allow).toContain("delete_file");
   });
 
   test("modelRole is review", () => {

src/agent/directors/draper/package.test.ts

@@ -76,13 +76,13 @@ describe("draperPackage", () => {
     expect(draperPackage.spawn.maySpawn).toBe(false);
   });
 
-  test("tools.allow is review surface without product writes", () => {
+  test("tools.allow is review surface with product writes", () => {
     const allow = draperPackage.tools?.allow ?? [];
     expect(allow).toContain("read_file");
     expect(allow).not.toContain("use_skill");
-    expect(allow).not.toContain("write_file");
-    expect(allow).not.toContain("edit_file");
-    expect(allow).not.toContain("delete_file");
+    expect(allow).toContain("write_file");
+    expect(allow).toContain("edit_file");
+    expect(allow).toContain("delete_file");
   });
 
   test("modelRole is review", () => {

src/agent/directors/emil/package.test.ts

@@ -73,13 +73,13 @@ describe("emilPackage", () => {
     expect(emilPackage.spawn.maySpawn).toBe(false);
   });
 
-  test("tools.allow is review surface without product writes", () => {
+  test("tools.allow is review surface with product writes", () => {
     const allow = emilPackage.tools?.allow ?? [];
     expect(allow).toContain("read_file");
     expect(allow).not.toContain("use_skill");
-    expect(allow).not.toContain("write_file");
-    expect(allow).not.toContain("edit_file");
-    expect(allow).not.toContain("delete_file");
+    expect(allow).toContain("write_file");
+    expect(allow).toContain("edit_file");
+    expect(allow).toContain("delete_file");
   });
 
   test("modelRole is review", () => {

src/agent/directors/explore/package.test.ts

@@ -82,13 +82,13 @@ describe("explorePackage", () => {
     expect(explorePackage.spawn.maySpawn).toBe(false);
   });
 
-  test("tools.allow is read-only (no product writes)", () => {
+  test("tools.allow mounts product writes (lane: no product edits)", () => {
     const allow = explorePackage.tools?.allow ?? [];
     expect(allow).toContain("read_file");
     expect(allow).toContain("grep");
-    expect(allow).not.toContain("write_file");
-    expect(allow).not.toContain("edit_file");
-    expect(allow).not.toContain("delete_file");
+    expect(allow).toContain("write_file");
+    expect(allow).toContain("edit_file");
+    expect(allow).toContain("delete_file");
   });
 
   test("modelRole is explore", () => {

src/agent/directors/explore/package.ts

@@ -1,5 +1,5 @@
 import type { DirectorPackage } from "../types.js";
-import { READ_TOOLS } from "../tool-sets.js";
+import { REVIEW_TOOLS } from "../tool-sets.js";
 
 /**
  * Explorer leaf (CL-7020).
@@ -33,7 +33,7 @@ FINDINGS SHAPE: Findings must be a scannable map — key paths, symbols, call fl
 FINISH BIAS: Prefer one thorough pass then report. Expand Findings, change approach, or write the final report — do not keep re-reading the same paths.
 
 OUT OF LANE: product writes, drive-by fixes, shipping features, review severity theater, orchestration, spawning specialists, fleet discovery, becoming Builder/Critic/orchestrator as primary.`,
-  tools: { allow: READ_TOOLS },
+  tools: { allow: REVIEW_TOOLS },
   spawn: { maySpawn: false },
   tier: "leaf",
   modelRole: "explore",

src/agent/directors/gaasbot/package.test.ts

@@ -67,12 +67,12 @@ describe("gaasbotPackage", () => {
     expect(gaasbotPackage.spawn.maySpawn).toBe(false);
   });
 
-  test("denies product write tools (advice only)", () => {
+  test("mounts product write tools (lane discipline in prompts)", () => {
     const allow = gaasbotPackage.tools?.allow ?? [];
     expect(allow).toContain("read_file");
-    expect(allow).not.toContain("write_file");
-    expect(allow).not.toContain("edit_file");
-    expect(allow).not.toContain("delete_file");
+    expect(allow).toContain("write_file");
+    expect(allow).toContain("edit_file");
+    expect(allow).toContain("delete_file");
   });
 
   test("modelRole is plan", () => {